feat: support multibyte strings in substrReplace #57845
Draft
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@artengin , does you implementation have any profits over one-liner from https://www.php.net/manual/ru/ref.mbstring.php#121807 ? You have condition for negative offset, but your tests does not cover it. You may use negative offset example from #57838 Also, take a look, offset can be array of ints! Your code will fail with array, breaking backward compatibility. For reference, original tests with arrays https://github.com/php/php-src/blob/master/ext/standard/tests/strings/substr_replace.phpt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #57838
Added support for multibyte strings in
substrReplace. The problem was that PHP'ssubstr_replacedoes not handle multibyte characters correctly.