Remove redundant array_filter call in PostgresGrammar::customOperators() #57655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
PostgresGrammar::customOperators()method by replacing a redundant doublearray_filtercall with a single, explicit filter closure. This results in cleaner logic, fewer operations, and more explicit intent without changing behavior.Problem
The current implementation uses nested
array_filtercalls:This is redundant because:
array_filter($operators, 'is_string')filters to keep only string valuesarray_filter(...)without a callback removes falsy values (including empty strings)Solution
Replace the double filter with a single, explicit filter:
This approach:
Changes
File:
src/Illuminate/Database/Query/Grammars/PostgresGrammar.phpBefore:
After:
Testing
All existing tests pass, including the specific test that validates this behavior: