[13.x] Change InteractsWithData::string()
to return native string
#56866
+79
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
InteractsWithData::string()
(and thus, a popularFormRequest::string()
) method to return a native PHP string instead of aStringable
instance, making it consistent withConfig\Repository::string()
and avoiding unnecessary object instantiation when developers only need a string value.Good news:
InteractsWithData::str
will returnStringable
what is sort of inline with the\Illuminate\Support\Str
class name.Motivation
Currently, both
string()
andstr()
methods inInteractsWithData
returnStringable
instances, which creates:Config\Repository::string()
which returns native stringsStringable
methodsstring()
andstr()
methodsWith these changes,
\Illuminate\Config\Repository::string
and\Illuminate\Support\Traits\InteractsWithData::string
have the same behaviour and similar code:While this can be one of the most annoying upgrade steps, I think it: