[12.x] Return unprocessable response when parameter is not a valid UniqueStringId

src/Illuminate/Database/Eloquent/Concerns/HasUniqueStringIds.php

@@ -2,7 +2,7 @@
 
 namespace Illuminate\Database\Eloquent\Concerns;
 
-use Illuminate\Database\Eloquent\ModelNotFoundException;
+use Illuminate\Database\Eloquent\InvalidIdFormatException;
 
 trait HasUniqueStringIds
 {
@@ -99,10 +99,10 @@ public function getIncrementing()
      * @param  string|null  $field
      * @return never
      *
-     * @throws \Illuminate\Database\Eloquent\ModelNotFoundException
+     * @throws \Illuminate\Database\Eloquent\InvalidIdFormatException
      */
     protected function handleInvalidUniqueId($value, $field)
     {
-        throw (new ModelNotFoundException)->setModel(get_class($this), $value);
+        throw (new InvalidIdFormatException)->setModel(get_class($this), $value, $field);
     }
 }

src/Illuminate/Database/Eloquent/InvalidIdFormatException.php

@@ -0,0 +1,74 @@
+<?php
+
+namespace Illuminate\Database\Eloquent;
+
+use Illuminate\Support\Arr;
+
+/**
+ * @template TModel of \Illuminate\Database\Eloquent\Model
+ */
+class InvalidIdFormatException extends \RuntimeException
+{
+    /**
+     * Name of the affected Eloquent model.
+     *
+     * @var class-string<TModel>
+     */
+    protected $model;
+
+    /**
+     * The affected model IDs.
+     *
+     * @var array<int, int|string>
+     */
+    protected $ids;
+
+    /**
+     * Set the affected Eloquent model and instance id.
+     *
+     * @param  class-string<TModel>  $model
+     * @param  array<int, int|string>|int|string  $ids
+     * @param  string|null  $field
+     * @return $this
+     */
+    public function setModel($model, $ids = [], ?string $field = null)
+    {
+        $this->model = $model;
+        $this->ids = Arr::wrap($ids);
+
+        $this->message = 'Invalid key';
+        if ($field !== null) {
+            $this->message .= " [{$field}]";
+        }
+
+        $this->message .= " for model [{$model}]";
+
+        if (count($this->ids) > 0) {
+            $this->message .= ' '.implode(', ', $this->ids);
+        }
+
+        $this->message .= '.';
+
+        return $this;
+    }
+
+    /**
+     * Get the affected Eloquent model.
+     *
+     * @return class-string<TModel>
+     */
+    public function getModel()
+    {
+        return $this->model;
+    }
+
+    /**
+     * Get the affected Eloquent model IDs.
+     *
+     * @return array<int, int|string>
+     */
+    public function getIds()
+    {
+        return $this->ids;
+    }
+}

src/Illuminate/Foundation/Exceptions/Handler.php

@@ -16,6 +16,7 @@
 use Illuminate\Contracts\Debug\ShouldntReport;
 use Illuminate\Contracts\Foundation\ExceptionRenderer;
 use Illuminate\Contracts\Support\Responsable;
+use Illuminate\Database\Eloquent\InvalidIdFormatException;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Database\MultipleRecordsFoundException;
 use Illuminate\Database\RecordNotFoundException;
@@ -146,6 +147,7 @@ class Handler implements ExceptionHandlerContract
         BackedEnumCaseNotFoundException::class,
         HttpException::class,
         HttpResponseException::class,
+        InvalidIdFormatException::class,
         ModelNotFoundException::class,
         MultipleRecordsFoundException::class,
         RecordNotFoundException::class,
@@ -634,6 +636,7 @@ protected function prepareException(Throwable $e)
         return match (true) {
             $e instanceof BackedEnumCaseNotFoundException => new NotFoundHttpException($e->getMessage(), $e),
             $e instanceof ModelNotFoundException => new NotFoundHttpException($e->getMessage(), $e),
+            $e instanceof InvalidIdFormatException => new HttpException(422, $e->getMessage(), $e),
             $e instanceof AuthorizationException && $e->hasStatus() => new HttpException(
                 $e->status(), $e->response()?->message() ?: (Response::$statusTexts[$e->status()] ?? 'Whoops, looks like something went wrong.'), $e
             ),

tests/Integration/Routing/ImplicitModelRouteBindingTest.php

@@ -310,6 +310,32 @@ public function testImplicitRouteBindingChildHasUlids()
         $response = $this->getJson("/post/{$post->id}/tag-slug/{$tag->slug}");
         $response->assertJsonFragment(['id' => $tag->id]);
     }
+
+    public function test_invalid_key_returns_unprocessable()
+    {
+        $routeResolution = static fn (ImplicitBindingCommentByUuid $comment) => response()->json(['ok' => true]);
+
+        Route::middleware(['web'])->group(function () use ($routeResolution) {
+            Route::get('/comments/{comment}', $routeResolution);
+            Route::get('/comments-by-uuid/{comment:uuid}', $routeResolution);
+        });
+
+        $response = $this->getJson('comments/not-a-uuid');
+
+        $response->assertUnprocessable();
+        $response->assertJson([
+            'message' => 'Invalid key for model [Illuminate\\Tests\\Integration\\Routing\\ImplicitBindingCommentByUuid] not-a-uuid.',
+        ]);
+
+        // When explicitly setting a route key field
+        $response = $this->getJson('comments-by-uuid/1234!');
+
+        $response->assertUnprocessable();
+        // Then the key is specified
+        $response->assertJson([
+            'message' => 'Invalid key [uuid] for model [Illuminate\\Tests\\Integration\\Routing\\ImplicitBindingCommentByUuid] 1234!.',
+        ]);
+    }
 }
 
 class ImplicitBindingUser extends Model
@@ -357,6 +383,25 @@ public function getRouteKeyName()
     }
 }
 
+class ImplicitBindingCommentByUuid extends Model
+{
+    use HasUuids;
+
+    public $table = 'comments';
+
+    protected $fillable = ['slug', 'user_id'];
+
+    public function getRouteKeyName()
+    {
+        return 'uuid';
+    }
+
+    public function uniqueIds()
+    {
+        return ['uuid'];
+    }
+}
+
 class ImplicitBindingComment extends Model
 {
     use HasUuids;