Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on how to customize the passport authorization view #9874

Closed

Conversation

jonerickson
Copy link

Awhile ago I introduced a new feature to Passport laravel/passport#1629 that allows a user to customize the authorization view used. Before it defaulted to a generic blade template. The pattern followed what currently exists in Fortify. This adds the documentation on how to use the feature.

@hafezdivandari
Copy link
Contributor

This is going to change a little bit on Passport 13.x, related PR #9819 is in draft.

@jonerickson
Copy link
Author

@hafezdivandari looking at the 12 - 13 diff, it doesn't appear this implementation is affected. Can you elaborate on what will change that affects the authorization view response?

@hafezdivandari
Copy link
Contributor

This one: laravel/passport#1771

@jonerickson
Copy link
Author

jonerickson commented Sep 13, 2024

@hafezdivandari Great - thanks for the direction. Love the headless UI approach. Do you have any idea of when 13 would be released? Looking at the release schedule, there's been a couple years in between major releases. Based on that, it might be beneficial to merge this, and then just update it when 13 is merged. That's my recommendation. There wouldn't be much to update besides just making a note about the new headless UI approach and that the package no longer ships with any front end blade templates to handle the auth code flow. The underlying logic remains the same.

@hafezdivandari
Copy link
Contributor

We can release 13.x after laravel/passport#1750 has been merged. Please check #9819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants