[1.x] Do not allow updating quantities to zero (#174)

* Do not allow updating quantities to zero * Update src/Subscription.php * Update Subscription.php
laravel · Nov 15, 2022 · 1bef15e · 1bef15e
1 parent a30a3a8
commit 1bef15e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Subscription.php b/src/Subscription.php
@@ -445,6 +445,10 @@ public function updateQuantity($quantity, array $options = [])
     {
         $this->guardAgainstUpdates('update quantities');
 
+        if ($quantity < 1) {
+            throw new LogicException('Paddle does not allow subscriptions to have a quantity of zero.');
+        }
+
         $this->updatePaddleSubscription(array_merge($options, [
             'quantity' => $quantity,
             'prorate' => $this->prorate,

diff --git a/tests/Unit/SubscriptionTest.php b/tests/Unit/SubscriptionTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Unit;
 
 use Laravel\Paddle\Subscription;
+use LogicException;
 use PHPUnit\Framework\TestCase;
 
 class SubscriptionTest extends TestCase
@@ -36,4 +37,13 @@ public function test_it_can_determine_if_a_trial_has_expired()
 
         $this->assertFalse($subscription->hasExpiredTrial());
     }
+
+    public function test_it_cannot_update_its_quantity_to_zero()
+    {
+        $subscription = new Subscription();
+
+        $this->expectException(LogicException::class);
+
+        $subscription->updateQuantity(0);
+    }
 }