Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix box.json getting emptied on Ctrl-C #501

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Fix box.json getting emptied on Ctrl-C #501

merged 5 commits into from
Dec 2, 2024

Conversation

rforced
Copy link
Contributor

@rforced rforced commented Jul 19, 2024 •
edited
Loading

If you cancel out of the build process, box.json gets wiped.

  • We can check if the new value for box.json is null, and if so, don't overwrite anything.

Fixes laravel-zero/laravel-zero#338

@rforced
Copy link
Contributor Author

rforced commented Dec 2, 2024

@owenvoke any chance you could take a look at this?

@nunomaduro
Copy link
Member

faced this issue 1 million times, @owenvoke can you validate it?

owenvoke
owenvoke approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍🏻 So sorry I hadn't seen this one.

@owenvoke owenvoke merged commit 9e2c9d4 into laravel-zero:master Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exiting the "app:build" command removes/clears the "box.json" file
3 participants
@rforced @nunomaduro @owenvoke