Conversation
Contributor
Pyrefly Type Coverage
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-09-21 07:02:43.491828707 +0000
+++ /tmp/pyrefly_pr.txt 2026-09-21 07:02:30.295728360 +0000
@@ -3438,10 +3438,8 @@
--> tests/unit_tests/controllers/console/explore/test_message.py:66:22
ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `MessageStatus | SQLCoreOperations[MessageStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
--> tests/unit_tests/controllers/console/explore/test_saved_message.py:38:22
-ERROR Argument `Literal['uuid']` is not assignable to parameter `customize_token_strategy` with type `CustomizeTokenStrategy | SQLCoreOperations[CustomizeTokenStrategy]` in function `models.model.Site.__init__` [bad-argument-type]
- --> tests/unit_tests/controllers/console/explore/test_trial.py:87:34
ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
- --> tests/unit_tests/controllers/console/explore/test_trial.py:182:5
+ --> tests/unit_tests/controllers/console/explore/test_trial.py:116:5
ERROR Argument `() -> Session` is not assignable to parameter `session_factory` with type `sessionmaker[@_]` in function `sqlalchemy.orm.scoping.scoped_session.__init__` [bad-argument-type]
--> tests/unit_tests/controllers/console/explore/test_wraps.py:28:39
ERROR Argument `str` is not assignable to parameter `view` with type `(InstalledApp) -> str` in function `controllers.console.explore.wraps.decorator` [bad-argument-type]
|
hjlarry
added this pull request to stack #42630
September 21, 2026 07:03
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor/trial-suggested-questions #42644 +/- ##
====================================================================
Coverage 87.32% 87.32%
====================================================================
Files 5449 5452 +3
Lines 313783 313895 +112
Branches 63130 63137 +7
====================================================================
+ Hits 274007 274119 +112
Misses 34445 34445
Partials 5331 5331
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trial parameters, site, and dataset previews now share detached app admission and injected queries instead of carrying a controller-owned ORM session through the response. Preview admission still accepts a Trial registration or recommended-catalog membership independently of login, the trial feature switch, and account quotas.
Site and dataset queries return detached records scoped to the admitted app owner; parameters reuse the existing app-definition service. Catalog I/O and response icon signing run outside the preview repository sessions. Dataset IDs, duplicate handling, and the legacy page/limit metadata behavior are preserved.
Site errors now identify an unavailable site (
app_site_unavailable, 403) or unavailable owner (app_owner_unavailable, 403). A missing owner previously failed an assertion with 500. App detail and workflow detail retain their existing ORM path for the next migration.Stacked on #42635; merge that PR first.