Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Fix a bug that returns null when the passed path is a file. #12775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jiangbo721
Copy link
Contributor

Now it is changed to two parameters, if it is a folder, it will recursively get the files under the folder, if it is a single file address, it will only get the file. At the same time, the order of parameters is adjusted to be consistent with the display order, and the text is also optimised (to avoid users not knowing how to input parameters).

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Now it is changed to two parameters, if it is a folder, it will recursively get the files under the folder, if it is a single file address, it will only get the file.
At the same time, the order of parameters is adjusted to be consistent with the display order, and the text is also optimised (to avoid users not knowing how to input parameters).
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 15, 2025
@jiangbo721
Copy link
Contributor Author

jiangbo721 commented Jan 16, 2025

old:
image
image

new:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant