-
Notifications
You must be signed in to change notification settings - Fork 314
feat(serverless): add activation preflight before plugin invocation #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package serverless | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "net/url" | ||
| "time" | ||
|
|
||
| "github.com/langgenius/dify-plugin-daemon/pkg/utils/http_requests" | ||
| "github.com/langgenius/dify-plugin-daemon/pkg/utils/parser" | ||
| ) | ||
|
|
||
| type activationRequest struct { | ||
| InstanceID string `json:"instance_id"` | ||
| } | ||
|
|
||
| type activationResponse struct { | ||
| Ready bool `json:"ready"` | ||
| Endpoint string `json:"endpoint,omitempty"` | ||
| } | ||
|
|
||
| // ErrActivationTimeout indicates the plugin was not woken up and ready before the | ||
| // activation deadline elapsed. Callers should treat it as a failed invocation. | ||
| var ErrActivationTimeout = fmt.Errorf("timed out waiting for plugin to become ready") | ||
|
|
||
| // Activate performs the activation preflight against the serverless connector. | ||
| // It wakes a scaled-to-zero plugin (renewing its activity lease) and blocks until | ||
| // the plugin reports ready. instanceID is the connector function name of the | ||
| // target plugin. timeout bounds how long the daemon waits for readiness; the | ||
| // connector applies its own backstop as well. | ||
| // | ||
| // It returns nil once the plugin is ready, ErrActivationTimeout when the plugin | ||
| // is not ready within the window, or a wrapped error for any other failure. | ||
| func Activate(ctx context.Context, instanceID string, timeout time.Duration) error { | ||
| activateURL, err := url.JoinPath(baseurl.String(), "/v1/activation/activate") | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if timeout > 0 { | ||
| var cancel context.CancelFunc | ||
| ctx, cancel = context.WithTimeout(ctx, timeout) | ||
| defer cancel() | ||
| } | ||
|
|
||
| response, err := http_requests.Request( | ||
| client, | ||
| activateURL, | ||
| "POST", | ||
| http_requests.HttpContext(ctx), | ||
| http_requests.HttpHeader(map[string]string{ | ||
| "Authorization": SERVERLESS_CONNECTOR_API_KEY, | ||
| }), | ||
| http_requests.HttpPayloadJson(activationRequest{InstanceID: instanceID}), | ||
| ) | ||
| if err != nil { | ||
| if ctx.Err() != nil { | ||
| return ErrActivationTimeout | ||
| } | ||
| return fmt.Errorf("failed to request serverless connector activation: %w", err) | ||
| } | ||
| defer response.Body.Close() | ||
|
|
||
| body, _ := io.ReadAll(io.LimitReader(response.Body, 4*1024)) | ||
|
wylswz marked this conversation as resolved.
Outdated
|
||
|
|
||
| switch response.StatusCode { | ||
| case http.StatusOK: | ||
| parsed, err := parser.UnmarshalJsonBytes[activationResponse](body) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse activation response: %w", err) | ||
| } | ||
| if !parsed.Ready { | ||
| return ErrActivationTimeout | ||
| } | ||
| return nil | ||
| case http.StatusGatewayTimeout: | ||
| return ErrActivationTimeout | ||
| default: | ||
| return fmt.Errorf("unexpected response from serverless connector activation: status=%d body=%s", response.StatusCode, string(body)) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.