fix: reject malformed mcp header templates#482
Open
HwangJohn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${...}as env templatesWhy
MCP connector headers are allowed to reference credentials through env templates. Malformed templates like
Bearer ${TOKENshould fail closed rather than being passed through as literal header values.No dedicated issue; found during MCP connector hardening.
Testing
corepack pnpm exec vitest run test/mcp-client.test.tspassedcorepack pnpm run format:checkpassedcorepack pnpm run lint:checkpassedcorepack pnpm run typecheckpassedgit diff --checkpassedcorepack pnpm testwas attempted on Windows and still fails outside this change in existingtest/env-behavior.test.tsHOME/permission assertions plus timeout-prone Mermaid/jsdom tests