Skip to content

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 10, 2025

Make core tests work with Pydantic 2.12

@cbornet cbornet requested a review from eyurtsev as a code owner October 10, 2025 17:13
@github-actions github-actions bot added core Related to the package `langchain-core` infra Chores, devops, repo meta changes labels Oct 10, 2025
Copy link

codspeed-hq bot commented Oct 10, 2025

CodSpeed Performance Report

Merging #33422 will not alter performance

Comparing cbornet:core-pydantic-2.12 (120693f) with master (41fe18b)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched
⏩ 21 skipped2

Footnotes

  1. No successful run was found on master (9140a7c) during the generation of this report, so 41fe18b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cbornet cbornet marked this pull request as draft October 11, 2025 16:42
@cbornet
Copy link
Collaborator Author

cbornet commented Oct 11, 2025

Probably need something like what was done in #30554 to pass the tests.

@cbornet
Copy link
Collaborator Author

cbornet commented Oct 12, 2025

@cbornet cbornet force-pushed the core-pydantic-2.12 branch from 869cd5b to a6cfa8a Compare October 12, 2025 17:49
@cbornet cbornet changed the title chore(core): lock pydantic version to 2.12 fix(core): support pydantic 2.12 Oct 12, 2025
@github-actions github-actions bot added fix and removed infra Chores, devops, repo meta changes labels Oct 12, 2025
@cbornet cbornet force-pushed the core-pydantic-2.12 branch 2 times, most recently from ac6eaff to 2520d6e Compare October 12, 2025 17:56
@cbornet cbornet marked this pull request as ready for review October 12, 2025 17:57
@cbornet cbornet force-pushed the core-pydantic-2.12 branch 2 times, most recently from e4298eb to cddc179 Compare October 12, 2025 18:09
@github-actions github-actions bot added langchain Related to the package `langchain` standard-tests Related to the package `standard-tests` text-splitters Related to the package `text-splitters` v1 Issue specific to LangChain 1.0 labels Oct 12, 2025
@cbornet cbornet force-pushed the core-pydantic-2.12 branch from cddc179 to 0691a54 Compare October 13, 2025 08:39
@cbornet cbornet requested review from ccurme and mdrxy as code owners October 13, 2025 08:39
@github-actions github-actions bot added integration Related to a provider partner package integration fix and removed fix labels Oct 13, 2025
@cbornet cbornet changed the title fix(core): support pydantic 2.12 fix: support pydantic 2.12 Oct 13, 2025
@github-actions github-actions bot added fix and removed fix labels Oct 13, 2025
@cbornet
Copy link
Collaborator Author

cbornet commented Oct 13, 2025

It seems Codspeed fails for deepseek and fireworks independently of this PR.

@cbornet cbornet force-pushed the core-pydantic-2.12 branch from 0691a54 to 120693f Compare October 14, 2025 15:25
@cbornet cbornet changed the title fix: support pydantic 2.12 fix(core): support pydantic 2.12 Oct 14, 2025
@github-actions github-actions bot added fix and removed fix labels Oct 14, 2025
@cbornet
Copy link
Collaborator Author

cbornet commented Oct 14, 2025

Closing in favor of #33461 and #33477

@cbornet cbornet closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the package `langchain-core` fix integration Related to a provider partner package integration langchain Related to the package `langchain` standard-tests Related to the package `standard-tests` text-splitters Related to the package `text-splitters` v1 Issue specific to LangChain 1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant