feat(langchain): add ruff rules SLF #32112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
cbornet
commented
Jul 19, 2025
| @@ -190,14 +190,14 @@ def __iter__(self: AgentExecutorIterator) -> Iterator[AddableDict]: | |||
| name=self.run_name, | |||
| ) | |||
| try: | |||
| while self.agent_executor._should_continue( | |||
| while self.agent_executor._should_continue( # noqa: SLF001 | |||
There was a problem hiding this comment.
It's OK for AgentExecutorIterator to access private members of AgentExecutor
CodSpeed WallTime Performance ReportMerging #32112 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32112 will not alter performanceComparing Summary
|
|
Nit - probably not really a feature, right? More like a chore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/private-member-access/