feat(langchain): add ruff rules ARG #32110
Open
+293
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
cbornet
commented
Jul 19, 2025
| @@ -749,18 +751,6 @@ def return_values(self) -> list[str]: | |||
| """Return values of the agent.""" | |||
| return ["output"] | |||
|
|
|||
| def _fix_text(self, text: str) -> str: | |||
There was a problem hiding this comment.
This method is private and doesn't seem to be used anywhere.
OK to remove it ?
CodSpeed WallTime Performance ReportMerging #32110 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32110 will not alter performanceComparing Summary
|
cbornet
force-pushed
the
langchain-ruff-arg
branch
from
0b78637 to
9c56fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#flake8-unused-arguments-arg