fix(core): correctly resolve list indices in JSON Pointer refs and improve docs #32041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and add thorough docs * Handle numeric path tokens as zero-based list indices when the current node is a list, preventing false-negative look-ups and KeyErrors. * Raise explicit “index out of range” errors for invalid indices. * Keep existing dict-key resolution behaviour intact. * Tighten validation: ensure every $ref starts with “#”. * Return a deep copy of the resolved fragment to avoid accidental mutation. * Added detailed doc-string and inline comments to clarify control flow, pointer semantics, and error cases.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
CodSpeed WallTime Performance ReportMerging #32041 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32041 will not alter performanceComparing Summary
|
eyurtsev
requested changes
Jul 15, 2025
will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes incorrect handling of numeric path tokens in internal JSON-Schema $ref resolution. Numeric tokens are now treated as zero-based list indices whenever the current node is a list, eliminating false-negative look-ups and spurious KeyErrors. The helper also raises an explicit “index out of range” error for invalid indices, validates that every reference starts with #, and returns a deep copy to prevent unintended mutation. A comprehensive doc-string and inline comments clarify pointer semantics, control flow, and error cases.
Issue: $ref paths with list indices (e.g. #/anyOf/0) raise KeyError in dereference_refs #32042
Dependencies:: None