-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add Valthera integration #30105
Conversation
vselvarajijay
commented
Mar 4, 2025
•
edited
Loading
edited
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @ccurme - I would really appreciate a review on my first PR to LangChain. Happy to make any refinements if I missed anything. Appreciate the review and feedback! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I left some in-line comments on the provider page. Remaining things to do:
- Add
langchain-valthera
to the package registry. - Revert changes to the integration template in
langchain-cli
anduv.lock
. - Pypi page has some issues:
- It documents
ChatValthera
,ValtheraEmbeddings
, and other abstractions that do not appear to exist. - The homepage is the langchain monorepo instead of https://github.com/valthera/valthera.
- It documents
@ccurme Thanks for the review! It looks like I had some old templates there, I cleared out the abstractions I wasn’t implementing.
|
"source": [ | ||
"# Valthera\n", | ||
"\n", | ||
"Enable AI agents to engage users when they're most likely to.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) most likely to what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah good call. Hopefully this is better:
Enable AI agents to engage users when they're most likely to respond.
print("✅ ValtheraTool successfully initialized for LangChain integration!") | ||
``` | ||
|
||
### Example 2: Using ValtheraTool with LangChain Agents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing this and just keeping the langgraph example.
See the admonition on the API reference for create_react_agent
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - cleared out the LangGraph examples and only keeping LangChain
Hey @ccurme - a few more fixes on this PR as you suggested also a couple others I wanted to improve:
Let me know if you think this is can be a good starting place for the Valthera tool. There is quite a bit more I would like to iterate on with the developer experience and capabilities that can help LLM Agents engage with people. |
# Conflicts: # libs/packages.yml