Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain: clean pyproject ruff section #30070

Merged
merged 3 commits into from
Mar 9, 2025
+17 −30
Merged

langchain: clean pyproject ruff section #30070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd5c107
sync lint group in makefile
dskarbrevik Mar 3, 2025
db9b45e
cleanup pyproject ruff section
dskarbrevik Mar 3, 2025
bae7589
remove need for explicit syncs
ccurme Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

.EXPORT_ALL_VARIABLES:
UV_FROZEN = true
UV_NO_SYNC = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set this at the top as a convenience for running make api_docs_quick_preview locally, but maybe that was a bad idea. make format should now sync automatically. Let me know if this doesn't work for you.


## help: Show this help info.
help: Makefile
Expand Down
10 changes: 1 addition & 9 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ ignore-words-list = 'momento,collison,ned,foor,reworkd,parth,whats,aapply,mysogy

[tool.ruff]
extend-include = ["*.ipynb"]
extend-exclude = [
"docs/docs/expression_language/why.ipynb", # TODO: look into why linter errors
]

[tool.ruff.lint]
select = ["D"]
Expand All @@ -96,9 +93,4 @@ pydocstyle = { convention = "google" }
"F841", # allow assignments to variables that are never read -- it's example code

]
"!libs/langchain/langchain/model_laboratory.py" = ["D"]

# These files were failing the listed rules at the time ruff was adopted for notebooks.
# Don't require them to change at once, though we should look into them eventually.
"cookbook/gymnasium_agent_simulation.ipynb" = ["F821"]
"docs/docs/integrations/document_loaders/tensorflow_datasets.ipynb" = ["F821"]
"!libs/langchain/langchain/model_laboratory.py" = ["D"]
36 changes: 16 additions & 20 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading