Format / lint the repo #648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few issues while doing my first PR:
So this PR proposes two solutions:
I also made a slight tweak to the pyproject.toml file (which can / probably should also be linted) to not use strings for boolean TOML settings
There are still linting errors but they mostly fall into two categories: very long strings and unused variables. Decided to leave those and tackle them in a separate review. At least they won't get picked up by auto formatters / linters, but you will just see them in your editor if you have ruff / mypy enabled