Skip to content

Conversation

awg66
Copy link
Contributor

@awg66 awg66 commented Sep 18, 2025

I noticed a few issues while doing my first PR:

  • Ruff was locked to version 0.1.35. The latest version is 0.13.0!
  • Running the format / lint commands results in a lot of failures with master. This means that when submitting PRs for actual code changes, if your editor is setup to auto lint / format on save (like mine) you end up picking up a lot of extraneous code changes

So this PR proposes two solutions:

  • Update pyproject.toml to bring ruff up-to-date from the stone-age
  • Run the formatter / linter and commit the results!

I also made a slight tweak to the pyproject.toml file (which can / probably should also be linted) to not use strings for boolean TOML settings

There are still linting errors but they mostly fall into two categories: very long strings and unused variables. Decided to leave those and tackle them in a separate review. At least they won't get picked up by auto formatters / linters, but you will just see them in your editor if you have ruff / mypy enabled

Copy link
Collaborator

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awg66! We're already planning on including the ruff upgrade and linting with the v1.0.0 release changes pending in PR #597, but probably no harm committing this now.

@michaelnchin michaelnchin merged commit 33af829 into langchain-ai:main Sep 19, 2025
12 checks passed
@awg66 awg66 deleted the lint_the_repo branch September 19, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants