generated from langchain-ai/integration-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 201
feat: Add document creation for ChatBedrockConverse #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hatMatch
wants to merge
16
commits into
langchain-ai:main
Choose a base branch
from
hatMatch:feat/create_documents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4f4c25c
feat: add create_document class method to add easily add documents to…
mathewHatch 13fe759
test: add testing for create_document with simple document
mathewHatch 71a21ff
fix: fixed bugs in code
mathewHatch b4d8238
Update libs/aws/langchain_aws/chat_models/bedrock_converse.py
hatMatch 58c7ecb
fix: changed format to be required arg in create_document
mathewHatch 4812a05
fix: added enable_citations in create_document docstring for complete…
mathewHatch 003d288
fix: cleaned up format code as it is now required
mathewHatch 114bc30
fix: updated test_create_document to have a format as it is required
mathewHatch d648de1
tests: added integration test for use of ChatBedrockConverse.create_d…
mathewHatch 1842cfc
fix: parentheses now spelled correctly
mathewHatch 42ce460
fix: typo in tests
mathewHatch d757851
fix: invalid regex search would raise value error when invalid charac…
mathewHatch 40241bd
Merge branch 'main' into feat/create_documents
hatMatch 5ab49f9
Merge branch 'main' into feat/create_documents
hatMatch 574c149
fix: added accidental deletions back in
hatMatch 05730b6
Merge branch 'langchain-ai:main' into feat/create_documents
hatMatch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing
content
source currently fails becauseisinstance
is missing the second argument for type hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops good catch thanks!