-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Actions taken since previous resubmission: * Added documentation to lotrrs(), rrs(), and gating() about the levels of condition(s) * Fixed bug in lotrrs() that was mislabeling numerator and denominator levels of second condition * Added parameters 'c1n' and 'c2n' in lotrrs(), rrs(), and gating() to specify the numerator level
Ian Buller, PhD, MA
committed
Nov 30, 2020
1 parent
9c122c3
commit c143110
Showing
3 changed files
with
9 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,19 @@ | ||
## This is the third resubmission | ||
|
||
* Actions taken regarding feedback from Prof. Brian Ripley: | ||
* Removed 'ncdFlow', 'flowWorkspaceData', and 'knitr' from Suggests | ||
* Created a random data set 'randCyto' and all documentation | ||
* Updated examples and testthat to use 'randCyto' data | ||
* Updated vignette with clearer language | ||
## This is the fourth resubmission | ||
|
||
* Actions taken since previous resubmission: | ||
* Added documentation to lotrrs(), rrs(), and gating() about the levels of condition(s) | ||
* Fixed bug in lotrrs() that was mislabeling numerator and denominator levels of second condition | ||
* Added parameters 'c1n' and 'c2n' in lotrrs(), rrs(), and gating() to specify the numerator level | ||
|
||
## Test environments | ||
* local OS X install, R 3.6.3 | ||
* win-builder, (devel, oldrelease, release) | ||
* Rhub | ||
* Fedora Linux, R-devel, clang, gfortran | ||
* Ubuntu Linux 16.04 LTS, R-release, GCC | ||
* Windows Server 2008 R2 SP1, R-devel, 32⁄64 bit | ||
* Debian Linux, R-devel, GCC | ||
|
||
## R CMD check results | ||
0 errors | 0 warnings | 0 notes | ||
|
||
* Duration | ||
* local OS X install, R 3.6.3: 98 seconds | ||
* win-builder, devel: 337 seconds | ||
* win-builder, oldrelease: 302 seconds | ||
* win-builder, release: 345 seconds | ||
|
||
## Submitted by Maintainer |