Skip to content

Add composer conflict with incompatible service-manager release #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tux-rampage merged 2 commits into from
Nov 25, 2024
Merged

Add composer conflict with incompatible service-manager release #96

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd5dff4
Add composer conflict with incompatible service-manager release
tux-rampage Nov 20, 2024
edf3fc5
Update composer lock
tux-rampage Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"conflict": {
"zendframework/zend-di": "*",
"laminas/laminas-servicemanager-di": "*",
"laminas/laminas-servicemanager": "<3.13.0"
"laminas/laminas-servicemanager": "<3.13.0 || >=4.0.0"
Copy link
Copy Markdown
Member

@Ocramius Ocramius Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but composer.lock needs adjustment.

Also, older releases still affected :O

Copy link
Copy Markdown
Member Author

@tux-rampage tux-rampage Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Another option would be to add a conflict to laminas/laminas-service-manager with "laminas/laminas-di": "<4.0.0" as well.

Anyways composer may still pick two incompatible versions if the constraints are low enough.

},
"suggest": {
"laminas/laminas-servicemanager": "An IoC container without auto wiring capabilities"
Expand Down