Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Relax php constraint as per 2025-11-03 TSC meeting - #35

Merged
froschdesign merged 4 commits into
laminas:3.11.xfrom
froschdesign:feature/relax-php-version
Jan 29, 2026
Merged

Relax php constraint as per 2025-11-03 TSC meeting#35
froschdesign merged 4 commits into
laminas:3.11.xfrom
froschdesign:feature/relax-php-version

Conversation

@froschdesign

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@gsteel

gsteel commented Jan 29, 2026

Copy link
Copy Markdown
Member

Probably worth dropping calls to ReflectionProperty::setAccessible() to get green CI?

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>

@gsteel gsteel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @froschdesign - I'll leave it to you to merge & release in case you think its worth amending phpunit.xml to ignore any other deprecations for 8.5 👍

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign

Copy link
Copy Markdown
Member Author

in case you think its worth amending phpunit.xml to ignore any other deprecations for 8.5

Which variant do we prefer to use?

@gsteel

gsteel commented Jan 29, 2026

Copy link
Copy Markdown
Member

Set failOnDeprecation to false?

failOnDeprecation="true"
failOnNotice="true"
failOnWarning="true"
failOnPhpunitDeprecation="false"

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign
froschdesign merged commit b816433 into laminas:3.11.x Jan 29, 2026
14 checks passed
@froschdesign
froschdesign deleted the feature/relax-php-version branch January 29, 2026 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants