Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coset): shl overflow when getting the points #994

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

0xLucqs
Copy link
Contributor

@0xLucqs 0xLucqs commented Apr 5, 2025

For higher degree polynomials the twiddles weren't computed correctly because computing the coset size would overflow. Fixed that by switching to u32 and added tests for higher degree polynomials

@0xLucqs 0xLucqs requested a review from a team as a code owner April 5, 2025 15:13
@diegokingston
Copy link
Collaborator

Hi! Thanks for the catch. In order to merge it, we need your commits to be signed (you can configure this by adding a signing key to your profile) and force pushing them.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (ca84326) to head (16d20c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files         160      160           
  Lines       35122    35130    +8     
=======================================
+ Hits        25306    25314    +8     
  Misses       9816     9816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegokingston diegokingston added this pull request to the merge queue Apr 8, 2025
Merged via the queue into lambdaclass:main with commit 201f08d Apr 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants