Add quartic extension baby bear u32 #956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 71.40% 71.49% +0.08%
==========================================
Files 155 156 +1
Lines 33574 33969 +395
==========================================
+ Hits 23975 24287 +312
- Misses 9599 9682 +83 ☔ View full report in Codecov by Sentry. |
nicole-graus
requested review from
Oppen,
diegokingston,
ilitteri and
entropidelic
pablodeymo
reviewed
Jan 22, 2025
math/benches/fields/baby_bear.rs
Outdated
| let mut result = Vec::with_capacity(num); | ||
| for _ in 0..result.capacity() { | ||
| result.push((F::from(random::<u64>()), F::from(random::<u64>()))); | ||
| } | ||
| result | ||
| } | ||
|
|
||
| pub fn rand_field_elements_u64(num: usize) -> Vec<(F64, F64)> { | ||
| let mut result = Vec::with_capacity(num); | ||
| for _ in 0..result.capacity() { |
There was a problem hiding this comment.
Suggested change
| for _ in 0..result.capacity() { | |
| for _ in 0..num { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Degree 4 extension field for Baby Bear in u32
Description
In this PR we add the Degree 4 Extension Field for our version of Baby Bear in u32. We also add the benchmarks for both versions of this extension (u64 and u32).
Results for 1 million operations:
Type of change
Checklist