Refactor AIR#937
Merged
MauroToscano merged 8 commits intomainfrom Nov 13, 2024
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 72.37% 70.99% -1.39%
==========================================
Files 153 153
Lines 33423 32770 -653
==========================================
- Hits 24191 23264 -927
- Misses 9232 9506 +274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ColoCarletti
requested review from
MauroToscano,
diegokingston and
entropidelic
entropidelic
reviewed
Nov 8, 2024
Comment on lines
+179
to
+181
| // FieldElement<A::FieldExtension>: AsBytes + Sync + Send, | ||
| // E: IsSubFieldOf<A::FieldExtension>, | ||
| // A::Field: IsSubFieldOf<E>, |
entropidelic
reviewed
Nov 8, 2024
Comment on lines
+196
to
+197
| // E: IsSubFieldOf<A::FieldExtension>, | ||
| // A::Field: IsSubFieldOf<E>, |
entropidelic
reviewed
Nov 8, 2024
Comment on lines
+247
to
+248
| // let (lde_trace_merkle_tree, lde_trace_merkle_root) = | ||
| // Self::batch_commit_main(&lde_trace_permuted_rows); |
entropidelic
reviewed
Nov 8, 2024
| )> | ||
| where | ||
| FieldElement<A::Field>: AsBytes + Send + Sync, | ||
| // FieldElement<E>: AsBytes + Send + Sync, |
entropidelic
reviewed
Nov 8, 2024
| FieldElement<A::Field>: AsBytes + Send + Sync, | ||
| // FieldElement<E>: AsBytes + Send + Sync, | ||
| FieldElement<A::FieldExtension>: AsBytes + Send + Sync, | ||
| // E: IsSubFieldOf<A::FieldExtension> + IsFFTField, |
entropidelic
reviewed
Nov 8, 2024
| FieldElement<A::Field>: Send + Sync, | ||
| E: IsSubFieldOf<A::FieldExtension>, | ||
| A::Field: IsSubFieldOf<E>, | ||
| // F: IsFFTField, |
entropidelic
reviewed
Nov 8, 2024
Comment on lines
+575
to
+577
| // let trace_poly_coeffients: Vec<_> = deep_composition_coefficients | ||
| // .drain(..num_terms_trace) | ||
| // .collect(); |
entropidelic
reviewed
Nov 8, 2024
Comment on lines
+76
to
+81
| // /// Given a row index, returns a mutable reference to that row as a slice of field elements. | ||
| // pub fn get_row_mut(&mut self, row_idx: usize) -> &mut [FieldElement<F>] { | ||
| // let n_cols = self.width; | ||
| // let row_offset = row_idx * n_cols; | ||
| // &mut self.data[row_offset..row_offset + n_cols] | ||
| // } |
entropidelic
reviewed
Nov 8, 2024
Comment on lines
+389
to
+405
| // #[cfg(test)] | ||
| // mod test { | ||
| // use super::TraceTable; | ||
| // use lambdaworks_math::field::{element::FieldElement, fields::u64_prime_field::F17}; | ||
| // type FE = FieldElement<F17>; | ||
|
|
||
| #[test] | ||
| fn test_cols() { | ||
| let col_1 = vec![FE::from(1), FE::from(2), FE::from(5), FE::from(13)]; | ||
| let col_2 = vec![FE::from(1), FE::from(3), FE::from(8), FE::from(21)]; | ||
| // #[test] | ||
| // fn test_cols() { | ||
| // let col_1 = vec![FE::from(1), FE::from(2), FE::from(5), FE::from(13)]; | ||
| // let col_2 = vec![FE::from(1), FE::from(3), FE::from(8), FE::from(21)]; | ||
|
|
||
| let trace_table = TraceTable::from_columns(vec![col_1.clone(), col_2.clone()], 2, 1); | ||
| let res_cols = trace_table.columns(); | ||
| // let trace_table = TraceTable::from_columns(vec![col_1.clone(), col_2.clone()], 2, 1); | ||
| // let res_cols = trace_table.columns(); | ||
|
|
||
| assert_eq!(res_cols, vec![col_1, col_2]); | ||
| } | ||
| } | ||
| // assert_eq!(res_cols, vec![col_1, col_2]); | ||
| // } | ||
| // } |
entropidelic
approved these changes
Nov 8, 2024
Contributor
entropidelic
left a comment
entropidelic
left a comment
There was a problem hiding this comment.
lgtm, just remove the commented unused code :)
MauroToscano
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor AIR
This PR resumes the changes made for AIR in the following PRs: 834 and 697.
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.
Checklist