-
Notifications
You must be signed in to change notification settings - Fork 126
perf(l1): improve rlp decoding #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edg-l
wants to merge
13
commits into
main
Choose a base branch
from
rlp_improve_decode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark Block Execution Results Comparison Against Main
|
Oppen
reviewed
Nov 26, 2025
Oppen
reviewed
Nov 26, 2025
Oppen
reviewed
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Basic integers like u64 used static_left_pad, that uses a temporary zeroed array, now they directly produce the integer. Did this by using decode_be_integer_u64, whose result can be casted to the relevant iX and decode_be_integer_u128, separate to avoid paying the cost of u128 always.
Modified decode_rlp_item so that it doesnt use
usize::from_be_bytes(static_left_pad(x)), and instead uses a dedicated methodparse_be_lengthwhich has less overhead.Improved static_left_pad to not always zero init an array, and added the special case for data.len() == N to avoid a saturating sub.
Helps with #4956