feat(l2): accelerate deployer #5394

avilagaston9 · 2025-11-20T03:35:17Z

Motivation

Our deployer currently waits for all transaction receipts before moving on to the next transaction.

Description

Send all transactions asynchronously and wait for all receipts at the end.

Closes None

github-actions · 2025-11-20T03:37:51Z

Lines of code report

Total lines added: 297
Total lines removed: 0
Total lines changed: 297

Detailed view

+----------------------------------+-------+------+
| File                             | Lines | Diff |
+----------------------------------+-------+------+
| ethrex/cmd/ethrex/l2/deployer.rs | 1321  | +184 |
+----------------------------------+-------+------+
| ethrex/crates/l2/sdk/src/sdk.rs  | 1072  | +113 |
+----------------------------------+-------+------+

avilagaston9 · 2025-11-20T03:40:03Z

crates/l2/sdk/src/sdk.rs

    let deploy_tx_hash =
        send_tx_bump_gas_exponential_backoff(eth_client, deploy_tx, deployer).await?;

-    wait_for_transaction_receipt(deploy_tx_hash, eth_client, 10).await?;


send_tx_bump_gas_exponential_backoff already waits for the receipt

Copilot

Pull Request Overview

This PR accelerates the L2 contract deployer by sending all transactions asynchronously and waiting for receipts at the end, rather than waiting for each transaction individually.

Key Changes:

Created non-waiting versions of deployment and initialization functions (*_no_wait) in the SDK
Modified the deployer to send all deployment transactions first, then all initialization transactions, and finally wait for all receipts in batch
Added explicit nonce management throughout to ensure correct transaction ordering when not waiting for receipts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
crates/l2/sdk/src/sdk.rs	Added non-waiting versions of deployment functions (`create2_deploy_no_wait`, `deploy_proxy_no_wait`, `deploy_with_proxy_from_bytecode_no_wait`, etc.) and refactored existing functions to support asynchronous operations with manual nonce management
cmd/ethrex/l2/deployer.rs	Updated deployment and initialization logic to use non-waiting functions, added explicit nonce tracking, collected transaction hashes, and implemented batch receipt waiting at the end of the process

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmd/ethrex/l2/deployer.rs

crates/l2/sdk/src/sdk.rs

ManuelBilbao · 2025-11-21T17:12:11Z

cmd/ethrex/l2/deployer.rs

+        }
+        let receipt = wait_for_transaction_receipt(tx_hash, &eth_client, 100).await?;
+        if !receipt.receipt.status {
+            error!("Receipt status is false for tx_hash: {:#x}", tx_hash);


Nit

Suggested change

error!("Receipt status is false for tx_hash: {:#x}", tx_hash);

error!("Receipt status is false for tx_hash: {tx_hash:#x}");

Done 2146f6e!

ManuelBilbao · 2025-11-21T17:12:48Z

cmd/ethrex/l2/deployer.rs

+        info!(
+            "Gas used for tx_hash {:#x}: {}",
+            tx_hash, receipt.tx_info.gas_used
+        );


Suggested change

info!(

"Gas used for tx_hash {:#x}: {}",

tx_hash, receipt.tx_info.gas_used

);

info!(

"Gas used for tx_hash {tx_hash:#x}: {}",

receipt.tx_info.gas_used

);

This log was for debugging. Removed 2146f6e!

ManuelBilbao · 2025-11-21T17:13:02Z

cmd/ethrex/l2/deployer.rs

+        }
+        let receipt = wait_for_transaction_receipt(tx_hash, &eth_client, 100).await?;
+        if !receipt.receipt.status {
+            error!("Receipt status is false for tx_hash: {:#x}", tx_hash);


Suggested change

error!("Receipt status is false for tx_hash: {:#x}", tx_hash);

error!("Receipt status is false for tx_hash: {tx_hash:#x}");

ManuelBilbao · 2025-11-21T17:14:10Z

cmd/ethrex/l2/deployer.rs

+
+    info!("Waiting for initialization transactions receipts");
+
+    for tx_hash in initialize_tx_hashes {


We should do something like depoy_tx_hashes.extend(initialize_tx_hashes) and iterate that to avoid repeating code

Done 2146f6e!

ManuelBilbao · 2025-11-21T17:19:02Z

cmd/ethrex/l2/deployer.rs

+                        ..Default::default()
+                    },
+                )
+                .await?;


I'd increment the nonce here even tough we don't use it anymore, to avoid future problems if we add some new transaction

Compiler complains with:

value assigned to `nonce` is never read

ManuelBilbao · 2025-11-21T17:24:17Z

cmd/ethrex/l2/deployer.rs

            info!(
                transfer_tx_hash = %format!("{transfer_tx_hash:#x}"),
                accept_tx_hash = %format!("{accept_tx_hash:#x}"),
                "CommonBridge ownership transferred and accepted"
            );
+            info!("Used nonce {}", nonce);


Suggested change

info!(

transfer_tx_hash = %format!("{transfer_tx_hash:#x}"),

accept_tx_hash = %format!("{accept_tx_hash:#x}"),

"CommonBridge ownership transferred and accepted"

);

info!("Used nonce {}", nonce);

info!(

transfer_tx_hash = %format!("{transfer_tx_hash:#x}"),

accept_tx_hash = %format!("{accept_tx_hash:#x}"),

nonce,

"CommonBridge ownership transferred and accepted"

);

This log was for debugging. Removed!

ManuelBilbao · 2025-11-21T17:25:01Z

cmd/ethrex/l2/deployer.rs

+                ..Default::default()
+            },
        )
        .await?;


I think a nonce increment is missing here

Done 2146f6e!

ManuelBilbao · 2025-11-21T17:25:44Z

cmd/ethrex/l2/deployer.rs

            let accept_tx_hash = send_generic_transaction(eth_client, accept_tx, &signer).await?;
-            wait_for_transaction_receipt(accept_tx_hash, eth_client, 100).await?;
+
+            tx_hashes.push(accept_tx_hash);


Same here about incrementing the nonce even it's not needed

ManuelBilbao · 2025-11-21T17:29:05Z

crates/l2/sdk/src/sdk.rs

 }

+/// Same as `deploy_with_proxy`, but does not wait for the transaction receipts.
+pub async fn deploy_with_proxy_no_wait(


Isn't this the same as deploy_with_proxy?

You are right. Refactored here 2146f6e!

ManuelBilbao · 2025-11-21T17:32:11Z

crates/l2/sdk/src/sdk.rs

-/// without the `COMPILE_CONTRACTS` env var set. In that case, this function
-/// will return `DeployError::ProxyBytecodeNotFound`.
-async fn deploy_proxy(
+pub async fn create2_deploy_from_bytecode_no_wait(


I'd make the regular version call the _no_wait version and the wait for the receipt. I think that would be less repeatitive

Done 2146f6e!

feat(l2): accelerate deployer

3456a19

github-actions bot assigned avilagaston9 Nov 20, 2025

github-actions bot added the L2 Rollup client label Nov 20, 2025

github-project-automation bot added this to ethrex_l2 Nov 20, 2025

avilagaston9 commented Nov 20, 2025

View reviewed changes

avilagaston9 marked this pull request as ready for review November 20, 2025 03:41

Copilot AI review requested due to automatic review settings November 20, 2025 03:41

avilagaston9 requested a review from a team as a code owner November 20, 2025 03:41

avilagaston9 moved this to In Review in ethrex_l2 Nov 20, 2025

Copilot started reviewing on behalf of avilagaston9 November 20, 2025 03:41 View session

Copilot finished reviewing on behalf of avilagaston9 November 20, 2025 03:46

Copilot AI reviewed Nov 20, 2025

View reviewed changes

ManuelBilbao reviewed Nov 21, 2025

View reviewed changes

gianbelinche approved these changes Nov 25, 2025

View reviewed changes

Fix PR

2146f6e

	error!("Receipt status is false for tx_hash: {:#x}", tx_hash);
	error!("Receipt status is false for tx_hash: {tx_hash:#x}");


		info!("Waiting for initialization transactions receipts");

		for tx_hash in initialize_tx_hashes {

feat(l2): accelerate deployer #5394

Are you sure you want to change the base?

feat(l2): accelerate deployer #5394

Conversation

avilagaston9 commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lines of code report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 20, 2025 •

edited

Loading