Skip to content

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Nov 19, 2025

Motivation

KZG signature verification takes a lot of time in flamegraphs.

Description

There are two changes here:

  1. A fix to behavior, we should reject peers that send us unsolicited
    responses;
  2. An optimizatino, we no longer revalidate a blob transaction that
    passed the verifications in PooledTransactions::validate_requested.

The first one might be a bit controversial. I want feedback on it and
will probably resend as a separate PR after. In my view, the current
behavior is an attack vector for DoS.

There are two changes here:
1. A fix to behavior, we should reject peers that send us unsolicited
   responses;
2. An optimizatino, we no longer revalidate a blob transaction that
   passed the verifications in PooledTransactions::validate_requested.
@github-actions github-actions bot added L1 Ethereum client performance Block execution throughput and performance in general labels Nov 19, 2025
@github-actions
Copy link

Lines of code report

Total lines added: 29
Total lines removed: 0
Total lines changed: 29

Detailed view
+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs                 | 1377  | +21  |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 1045  | +8   |
+--------------------------------------------------------+-------+------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client performance Block execution throughput and performance in general

Projects

Status: No status
Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants