Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout paddings. #546

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix layout paddings. #546

merged 1 commit into from
Apr 25, 2024

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 marked this pull request as ready for review April 24, 2024 19:13
@azteca1998 azteca1998 linked an issue Apr 24, 2024 that may be closed by this pull request
Copy link

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.498 ± 0.217 13.362 14.104 31.06 ± 0.51
cairo-native (embedded AOT) 1.553 ± 0.008 1.538 1.568 3.57 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 1.528 ± 0.007 1.514 1.539 3.52 ± 0.02
cairo-native (standalone AOT) 0.637 ± 0.004 0.634 0.646 1.47 ± 0.01
cairo-native (standalone AOT with -march=native) 0.435 ± 0.001 0.433 0.437 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 12.955 ± 0.043 12.913 13.041 1596.28 ± 18.97
cairo-native (embedded AOT) 1.078 ± 0.004 1.073 1.085 132.80 ± 1.58
cairo-native (embedded JIT using LLVM's ORC Engine) 1.100 ± 0.008 1.083 1.112 135.49 ± 1.82
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.008 1.02 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.850 ± 0.025 1.818 1.915 27.30 ± 0.37
cairo-native (embedded AOT) 1.192 ± 0.011 1.180 1.220 17.58 ± 0.17
cairo-native (embedded JIT using LLVM's ORC Engine) 1.424 ± 0.008 1.408 1.434 21.02 ± 0.13
cairo-native (standalone AOT) 0.112 ± 0.000 0.111 0.112 1.65 ± 0.00
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.068 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (876b3a9) to head (9c45758).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         108      108           
  Lines       34260    34261    +1     
=======================================
+ Hits        30674    30675    +1     
  Misses       3586     3586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit f44fd58 Apr 25, 2024
9 checks passed
@edg-l edg-l deleted the fix-layout-sizes branch April 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: parse result error
4 participants