Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syscall handler glue code array conversions. #502

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Mar 26, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.645 ± 0.081 13.536 13.808 31.36 ± 0.21
cairo-native (embedded AOT) 1.589 ± 0.011 1.568 1.604 3.65 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 1.569 ± 0.016 1.546 1.592 3.60 ± 0.04
cairo-native (standalone AOT) 0.638 ± 0.008 0.635 0.661 1.47 ± 0.02
cairo-native (standalone AOT with -march=native) 0.435 ± 0.001 0.434 0.437 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.139 ± 0.059 13.069 13.230 1592.47 ± 23.34
cairo-native (embedded AOT) 1.111 ± 0.009 1.098 1.130 134.64 ± 2.20
cairo-native (embedded JIT using LLVM's ORC Engine) 1.134 ± 0.017 1.120 1.166 137.43 ± 2.81
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.00 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.944 ± 0.037 1.891 2.017 28.58 ± 0.55
cairo-native (embedded AOT) 1.231 ± 0.007 1.222 1.246 18.10 ± 0.13
cairo-native (embedded JIT using LLVM's ORC Engine) 1.470 ± 0.007 1.463 1.481 21.61 ± 0.13
cairo-native (standalone AOT) 0.112 ± 0.000 0.112 0.112 1.64 ± 0.01
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.069 1.00

@azteca1998 azteca1998 marked this pull request as ready for review March 26, 2024 18:57
igaray
igaray previously approved these changes Mar 26, 2024
@igaray igaray added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 8ed3b29 Mar 26, 2024
9 checks passed
@igaray igaray deleted the fix-arrays-on-syscall-handler branch March 26, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BUG: incorrect nonce value
3 participants