-
Notifications
You must be signed in to change notification settings - Fork 47
[2.11.1] Implement blake libfunc #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.482 ± 0.053 | 11.428 | 11.600 | 2.29 ± 0.02 |
cairo-native (embedded AOT) |
5.018 ± 0.027 | 4.968 | 5.055 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.148 ± 0.075 | 5.038 | 5.263 | 1.03 ± 0.02 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
808.7 ± 10.3 | 797.1 | 825.5 | 1.00 |
cairo-native (embedded AOT) |
4906.5 ± 21.6 | 4873.7 | 4936.3 | 6.07 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5025.5 ± 50.0 | 4950.8 | 5112.5 | 6.21 ± 0.10 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.284 ± 0.042 | 5.189 | 5.334 | 1.00 |
cairo-native (embedded AOT) |
5.305 ± 0.027 | 5.258 | 5.338 | 1.00 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.361 ± 0.029 | 5.315 | 5.414 | 1.01 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.099 ± 0.015 | 5.067 | 5.115 | 1.05 ± 0.01 |
cairo-native (embedded AOT) |
4.853 ± 0.031 | 4.810 | 4.897 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.866 ± 0.030 | 4.828 | 4.928 | 1.00 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
836.8 ± 8.6 | 824.7 | 850.3 | 1.00 |
cairo-native (embedded AOT) |
4950.7 ± 35.1 | 4915.5 | 5026.5 | 5.92 ± 0.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5087.1 ± 32.6 | 5049.4 | 5165.7 | 6.08 ± 0.07 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
541.3 ± 9.9 | 535.6 | 568.7 | 1.00 |
cairo-native (embedded AOT) |
5001.2 ± 31.4 | 4954.0 | 5053.8 | 9.24 ± 0.18 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5187.6 ± 27.3 | 5149.8 | 5241.9 | 9.58 ± 0.18 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
+ Coverage 80.47% 80.63% +0.15%
==========================================
Files 110 112 +2
Lines 29571 29801 +230
==========================================
+ Hits 23798 24030 +232
+ Misses 5773 5771 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FrancoGiachetta! Left you some comments.
…ive into impl-blake-libfunc
✅ Code is now correctly formatted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is OK, but I'm not sure adding the blake utils to Native is the right choice:
- Can we import them from the Cairo VM
- Can we move them to a math-specific crate?
This PR implements both blake related libfuncs
Closes #1148, #1149
Checklist