LC-187: Fix failing Storybook tests in Data Table component #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing Storybook tests in the Data Table component by addressing the following issues:
Switch Component: Added
role="switch"
andaria-checked
attributes to make the component accessible and properly identifiable by testing tools.Form Context Hook: Improved the
useFormContext
hook to safely handle cases when it's used outside of a Formik context, preventing the "Cannot read properties of null" error.Radio Group Component: Enhanced the InputRadioGroup component to safely access Formik properties with optional chaining, preventing null reference errors.
Radio Component: Added proper ARIA attributes to the Radio component for better accessibility.
Changes Made
InputSwitch.tsx
to include proper ARIA attributesuseFormContext.ts
InputRadioGroup.tsx
with safer property accessInputRadio.tsx
These changes ensure that the components are properly accessible and work correctly in test environments.
Testing
The changes have been tested by running the Storybook tests as described in the issue:
Related Issues
Fixes LC-187
💻 View my work • About Codegen