This repository has been archived by the owner on Jan 15, 2023. It is now read-only.
Cast header Lambda-Runtime-Deadline-Ms to int for Python2.7/3.6 runtimes #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing an issue with 2.7 runtime when calling
get_remaining_time_in_millis
. It appears that in the runtime the variableDEADLINE_MS
is overwritten with a value pulled directly from a header, which is a string. Then whenget_remaining_time_in_millis
is called, it tries to subtract an int from a string, and so throws. This PR simply casts the received header value to an int before overwriting the variable.Proof of bug: