Merging upstream

[lallaria]

Fixed #29 and #36

---

Note

De-duplicates Archipelago item notifications using id+location and updates Streamer.bot trap action to return a random timed-out user via custom event response; bumps version to 1.2.7.

• Archipelago / Items:
  • De-duplicate received items using {id, locationId} keys instead of id offsets; persist and log LocationId.
• Streamer.bot / Webhook:
  • Trap flow now passes timedOutUser: "Chat", requests customEventResponse, and returns customEventResponseArgs.randomUser0 || "Chat".
• Logging:
  • saveItems callback logs the number of saved items.
• Version:
  • Bump package.json to 1.2.7.

^{Written by Cursor Bugbot for commit 2233672. This will update automatically on new commits. Configure here.}

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Type Mismatch Breaks Countdown Persistence

The countdown flag persistence uses .includes(696969) and .push(696969) with a primitive number, but notifiedItems now stores objects with { id, locationId } structure. This creates a type mismatch that breaks countdown state persistence, mixing primitives with objects in the array.

archipelagoHelper.js#L145-L149

Chatipelago/archipelagoHelper.js

Lines 145 to 149 in 2233672

	loadCache(); //make sure the cache is loaded
	if (notifiedItems.includes(696969)){
	return;
	} else {
	notifiedItems.push(696969)

 

---

[cursor]

Bug: Data Mismatch Breaks Countdown State

The countdown flag check uses .includes(696969) with a primitive number, but notifiedItems now stores objects with { id, locationId } structure. This check will always fail since .includes() compares objects by reference, breaking countdown state tracking.

 

[cursor]

Bug: Regression: Unsafe Data Access Causes Errors

The code accesses response.customEventResponseArgs.randomUser0 without null-checking customEventResponseArgs first. The previous implementation had null-checking (if (response.customEventResponseArgs && ...)). If customEventResponseArgs is undefined, this will throw TypeError instead of returning the "Chat" fallback.

 

[cursor]

Bug: Misleading Item Count in Debug Output

The debug message uses jsonItems.length which returns the character count of the JSON string, not the number of items. Since jsonItems is assigned JSON.stringify(collectedItems) on line 111, the logged value represents string length rather than item count as the message "items" suggests.