fix: spark-compatible date_trunc — timestamp return type, NULL on invalid unit, and unit from a column - #2237
Draft
davidlghellin wants to merge 11 commits into
Draft
fix: spark-compatible date_trunc — timestamp return type, NULL on invalid unit, and unit from a column#2237davidlghellin wants to merge 11 commits into
date_trunc — timestamp return type, NULL on invalid unit, and unit from a column#2237davidlghellin wants to merge 11 commits into
Codecov / codecov/project
succeeded
Jul 24, 2026 in 1s
78.04% (-1.41%) compared to b247b02
View this Pull Request on Codecov
78.04% (-1.41%) compared to b247b02
Details
Codecov Report
❌ Patch coverage is 85.71429% with 57 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
- Coverage 79.45% 78.04% -1.41%
==========================================
Files 909 911 +2
Lines 171731 172405 +674
==========================================
- Hits 136454 134561 -1893
- Misses 35277 37844 +2567 | Files with missing lines | Coverage Δ | |
|---|---|---|
| crates/sail-execution/src/proto/codec.rs | 47.32% <50.00%> (+<0.01%) |
⬆️ |
| ...il-function/src/scalar/datetime/spark_timestamp.rs | 82.82% <96.29%> (+2.59%) |
⬆️ |
| crates/sail-plan/src/function/scalar/datetime.rs | 87.67% <94.77%> (+0.80%) |
⬆️ |
| ...-function/src/scalar/datetime/spark_trunc_level.rs | 67.21% <67.21%> (ø) |
|
| ...l-function/src/scalar/datetime/spark_date_trunc.rs | 79.67% <82.69%> (+16.04%) |
⬆️ |
... and 77 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Loading