Skip to content

Fix GTK Tree double-click issue by delegating to Control's background context implementation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix GTK Tree double-click issue by delegating to Control's background context implementation #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
110ac76
Initial plan
Copilot Nov 13, 2025
e726de4
Initial analysis of GTK double-click focus issue
Copilot Nov 13, 2025
83c0392
Implement fix for GTK double-click focus issue
Copilot Nov 13, 2025
3e4036b
Remove accidentally added build script
Copilot Nov 13, 2025
5744a90
Correct fix based on investigation - modify Tree.getContextBackground…
Copilot Nov 14, 2025
50377a6
Improve fix: delegate to Control's getContextBackgroundGdkRGBA when c…
Copilot Nov 14, 2025
92be220
Remove accidentally added build script and update gitignore
Copilot Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ pom.tycho
/binaries/org.eclipse.swt.*/src/
tmpdir/
‎build_gtk.sh
build_gtk.sh
16 changes: 9 additions & 7 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,13 +1557,15 @@ public int getColumnCount () {

@Override
GdkRGBA getContextBackgroundGdkRGBA () {
if (background != null) {
return background;
} else {
// For Tables and Trees, the default background is
// COLOR_LIST_BACKGROUND instead of COLOR_WIDGET_BACKGROUND.
return defaultBackground();
}
// Bug 2702: When a custom background is set, delegate to Control's implementation
// which parses from the CSS provider. This prevents focus issues that occur when
// returning the stored background field value directly.
if (background != null && background != defaultBackground()) {
return super.getContextBackgroundGdkRGBA();
}
// For Tables and Trees, the default background is
// COLOR_LIST_BACKGROUND instead of COLOR_WIDGET_BACKGROUND.
return defaultBackground();
}

@Override
Expand Down