Skip to content

merge: upstream weekly syncs 09-14 through 10-05 (v1.18.34) + 10-19 from upstream/v1 (v1.19.3) - #46

Merged
lacymorrow merged 217 commits into
lashfrom
LAC-3879/upstream-sync-2026-09-14
Oct 19, 2026
Merged

lacymorrow merged 217 commits into
lashfrom
LAC-3879/upstream-sync-2026-09-14

Conversation

@lacymorrow

@lacymorrow lacymorrow commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Weekly upstream syncs from anomalyco/opencode into lash. This PR now carries five weeks. The first four merged upstream/dev; the 2026-10-19 week merges upstream/v1, because upstream promoted v2 to dev on 2026-10-10. See the 2026-10-19 section at the bottom.

  • 2026-09-14 (LAC-3879): upstream v1.18.30 merge (e43330c27e).
  • 2026-09-21 (LAC-3962): upstream v1.18.31 merge (1c2471149e) — 47 commits (228e9095ba..70a24697ea). Also merged origin/lash (v1.7.14 release + install fix 16e3ca300b) to keep the branch current.
  • 2026-09-28 (LAC-4045): upstream v1.18.33 merge (44308f12c8) — 38 commits (70a24697ea..03e67171ab).
  • 2026-10-05 (LAC-4139): upstream v1.18.34 merge (cf62c6b690) — 39 commits (03e67171ab..907b3bc518), mostly stats/console/docs plus macOS code-signing and namespaced session-identity headers.

Conflict resolution (2026-09-21)

  • 18 package.json version-line conflicts resolved in-place keeping lash 1.7.14 (no checkout --ours, per the pin-drop gotcha).
  • @ai-sdk/togetherai 2.0.41 → 2.0.68 bump auto-merged outside the hunks; verified present after resolution.
  • bun.lock restored from upstream base then bun install; float check clean (delta is internal versions only).
  • Complex files (prompt.ts, app.tsx, prompt/index.tsx, types.gen.ts, keybind.ts) untouched by upstream this week — no escalation.

Conflict resolution (2026-09-28)

  • 19 conflicts, all standard. 18 package.json version-line hunks resolved in place keeping lash versions (1.7.14; console/* stay 1.7.13). No checkout --ours, so no pin-drop.
  • bun.lock restored from the upstream base then bun install (never bun install over conflict markers — UPSTREAM_SYNC.md §13). Float check clean: the only delta vs upstream's lockfile is our 19 internal workspace version lines. Zero third-party drift.
  • Upstream dependency changes verified present after resolution (diffing merge-base → upstream/dev per conflicted file, since files reverted to ours vanish from git diff --cached):
    • packages/core: gitlab-ai-provider 6.15.0 → 6.18.0, open 11.0.4 added
    • packages/opencode: gitlab-ai-provider 6.15.0 → 6.18.0, open 10.1.2 removed
  • Complex files (prompt.ts, app.tsx, prompt/index.tsx, types.gen.ts, keybind.ts, bash.ts) untouched by upstream this window — no escalation.

Conflict resolution (2026-10-05)

  • 20 conflicts. 18 package.json version-line hunks resolved in place keeping lash versions (1.7.14; console/* stay 1.7.13). No checkout --ours, so no pin-drop.
  • Upstream dependency changes verified present after resolution (diffing merge-base → upstream/dev, since files reverted to ours vanish from git diff --cached). This window upstream removed things as part of retiring the S3 data lake, and the removals landed: ./athena export and @aws-sdk/client-athena gone from packages/stats/core, @aws-sdk/client-firehose gone, and packages/stats/server main/exports/start renamed to src/stat-sync.ts.
  • bun.lock restored from the upstream base then bun install. Float check clean: the only delta vs upstream's lockfile is our 19 internal workspace version lines. Zero third-party drift.
  • packages/opencode/test/cli/run/run-process.test.ts — a new conflict class worth reading. Both sides were independently fixing the same flake: the #27371 regression test asserts durationMs < 30_000, which gets noisy on loaded CI runners. Lash (LAC-2386) had widened the explanatory comment and kept cliIt.concurrent. Upstream switched the test to cliIt.live, which runs it serially so competing subprocess spawns stop charging against its wall clock — that fixes the cause rather than padding the budget, so I took upstream's version. I kept lash's observed >15s cold-start figure as a note against anyone later tightening the 30s number, since that datapoint still holds on 2-core runners. Verified by running the file: 13/13 pass.
  • Complex files (prompt.ts, app.tsx, prompt/index.tsx, types.gen.ts, keybind.ts, bash.ts) untouched by upstream this window — no escalation.

Invariants (verified)

  • agent_cycle: shift+tab (packages/tui/src/config/keybind.ts:130)
  • EventCwdUpdated present in types.gen.ts
  • getCwd(ctx.directory) (4 call sites), setCwd + cwd sentinel, detectNaturalLanguage in session/prompt.ts
  • prompt.mode.toggle binding in packages/tui/src/component/prompt/index.tsx

Testing

  • bun turbo typecheck: 30/30 tasks green (re-run after the 2026-10-05 merge).
  • bun test test/cli/run/run-process.test.ts: 13 pass / 0 fail — covers the hand-resolved cliIt.live conflict.

CI

All 8 checks were green on a4806697de (the 2026-09-28 head), including e2e (windows) (21m57s). CI for the 2026-10-05 merge is running on 0375bcaf8c.

Two upstream packages/app Playwright specs (open-file-expand-folder "trailing Windows separator", file-browser-sidebar-tab-switch "when switching file tabs") failed the Windows job on this branch's 2026-09-14 and 2026-09-21 runs and pass now. Upstream changed nothing in packages/app/src or either spec in the merged window (only version-sync commits), so the code under test is unchanged and these are flaky on Windows, not broken. Tracked as LAC-4138 so the flake gets fixed rather than re-diagnosed every sync. It is not a reason to hold this PR.

Not yet verified (why this is not self-merged)

Everything checkable without a terminal is checked: CI 8/8, typecheck 30/30, and the lash invariants verified in source, including the double-left-border row layout that regressed once before (LAC-163) — outer border={["left"]} with the ╹ connector, then flexDirection="row" wrapping a width={1} alignSelf="stretch" inner bar, at packages/tui/src/component/prompt/index.tsx:1442-1455.

What is not verified is the interactive half of the UPSTREAM_SYNC.md post-merge QA checklist: rendered border colors and equal bar heights, Tab vs Shift+Tab routing under real keypresses, execution-mode colors, and shell-mode cd updating the footer cwd. Those need a real terminal driving the OpenTUI app and cannot be done headlessly. That pass is tracked in LAC-3268 (todo, unassigned). One known open defect already sits in that area: LAC-3732, cd not updating the footer cwd, which predates this sync.

lash is the branch your daily shell runs from and this PR carries 161 commits, so I am leaving the merge to you rather than self-merging a four-week backlog that the mandated visual pass has not covered. Nothing technical is blocking it.

Paperclip: LAC-3879, LAC-3962, LAC-4045, LAC-4139. Process: UPSTREAM_SYNC.md.

2026-10-19 (LAC-4851): upstream split its lines, this week merges upstream/v1

Read this part first. The merge source changed.

On 2026-10-10 upstream merged 5caf1f9f6f chore: promote v2 to dev. upstream/dev is now OpenCode 2, and that merge deleted packages/opencode (commit 44b6938b2a, 700 files, 328k deletions). Every lash customization lives in packages/opencode: plugin/shell-mode/, plugin/tui-integration/, the cwd sentinel in src/session/prompt.ts, src/tool/. So merging upstream/dev is no longer a weekly sync, it is re-porting the fork onto a new architecture.

upstream/dev (OpenCode 2) upstream/v1 (maintenance)
commits since the 10-05 merge base 4735 53
files changed 8975 ~180
conflicted files 181 24
has packages/opencode no yes
version 2.x 1.19.3

Both branch from 907b3bc518, the exact upstream commit the 2026-10-05 sync landed on. This week merges upstream/v1, the OpenCode 1 maintenance line and the true continuation of the lineage lash has tracked all along. 53 commits, to v1.19.3.

The fork-direction decision is escalated to LAC-4864 (stay on v1 / port lash to OpenCode 2 / hard-fork), assigned to the CTO. This v1 merge is not wasted work under any of those outcomes, it keeps lash shippable while the call is made. UPSTREAM_SYNC.md now documents the split and points weekly runs at upstream/v1 so next Monday does not rediscover this.

This week also covers the 10-12 window, which never ran: LAC-4267 died on a token limit before doing any work.

Conflict resolution (2026-10-19)

24 conflicts.

  • 18 package.json version lines resolved in place keeping lash 1.7.14 (console/* stay 1.7.13). No checkout --ours, so no pin-drop.
  • Upstream dependency changes verified present after resolution, per the LAC-3413 gotcha: @ai-sdk/xai 3.0.102 → 3.0.139 in packages/core and packages/opencode, the matching patchedDependencies entry and patch-file rename in root package.json, and gitlab-ai-provider 6.18.0 → 6.19.0 in both.
  • bun.lock restored from the upstream/v1 base then bun install. Float check run without filters: the only changed lines in the whole lockfile are 17 internal 1.19.3 removals against 19 1.7.x additions. Zero third-party drift.
  • 3 workflow branch filters (nix-eval.yml, test.yml, typecheck.yml): upstream retargeted dev to v1. Kept lash's [dev, lash], since lash has no v1 branch.
  • packages/tui/src/app.tsx: upstream's new UpdateNotificationProvider (feat(tui): replace V1 auto-update with V2-style /update dialog anomalyco/opencode#54409, replaces V1 auto-update with the V2-style /update dialog) wrapped around lash's ExecutionModeProvider + WorkingDirProvider, per UPSTREAM_SYNC.md §8. Its import and the input.updater prop auto-merged.
  • install needed real care, and the auto-merge introduced a bug. Upstream rewrote release discovery to gate OpenCode 1 against OpenCode 2. The non-conflicting half of that rewrite merged a hard-coded anomalyco/opencode download URL into the lash installer, re-breaking exactly what PR fix(install): install lash, not opencode #48 (fix(install): install lash, not opencode) had just fixed. It sat outside the conflict markers, so nothing flagged it. Resolution:
    • Rejected upstream's 1-vs-2 version gating and its npm opencode-ai discovery. Lash has no v2 and its latest GitHub release is always lash.
    • Kept lash's release source, LASH_INSTALL_DIR, and $HOME/.lash/bin default.
    • Fixed the auto-merged URL to lacymorrow/lash, and dropped the now-dead releases/latest/download assignment that upstream's restructure superseded. Downloads now pin the resolved version instead of following the latest redirect, which closes a race between the API read and the redirect.
    • Took upstream's asset-existence preflight: curl -sIL "$url" against the asset instead of a HEAD on the tag page, plus its "if it was just released, try again in a few minutes" message. Lash has the same still-publishing race (see LAC-4453).
  • Complex files: prompt.ts, prompt/index.tsx, keybind.ts, bash.ts untouched by upstream this window. types.gen.ts and routes/home.tsx auto-merged clean. No escalation needed beyond the architectural one above.

script/install.test.ts retargeted at lash

Upstream added this file in anomalyco#54904 to cover its OpenCode 1-vs-2 gating. Merged as-is it asserted behavior lash deliberately does not have: anomalyco/opencode URLs, $HOME/.opencode/bin, and refusal of 2.x versions. It would have failed on lash the moment anyone ran it.

Retargeted at lash's installer, and added a guard for the regression above: the stub curl now exits 22 on every host except lacymorrow/lash, and one test asserts outright that no request mentions anomalyco or opencode. Also builds a zip on darwin rather than skipping, so the download and extract path is exercised outside linux CI. 7/7 pass.

Caveat worth knowing: these script/ tests do not run in CI, in lash or upstream. Root bunfig.toml sets [test] root = "./do-not-run-tests-from-root" and CI runs bun turbo test, which only covers packages. Filed as LAC-4872.

Invariants (verified, 2026-10-19)

  • agent_cycle: shift+tab at packages/tui/src/config/keybind.ts:130, agent_cycle_reverse: none
  • EventCwdUpdated in types.gen.ts (definition plus both union memberships)
  • getCwd(ctx.directory) at 4 call sites, setCwd + cwd sentinel parsing, detectNaturalLanguage in session/prompt.ts
  • prompt.mode.toggle on ctrl+space in packages/tui/src/component/prompt/index.tsx
  • double-left-border row layout (width={1} + alignSelf="stretch", not nested borders)
  • showWorkingDirectory={false} in routes/home.tsx, honored at prompt/index.tsx:1743
  • ExecutionModeProvider + WorkingDirProvider still wrap <App /> in app.tsx

Testing (2026-10-19)

  • bun turbo typecheck: 30/30 green, 0 errors.
  • bun test ./script/install.test.ts: 7 pass / 0 fail.
  • Every test file upstream touched this window, run locally: packages/tui dialog-update 7/7, packages/opencode upgrade + installation + cli/import 46/46, provider/openai + provider/provider + session/message-v2 + share/share-next + cli/help 146 total, packages/core/test/github-copilot 37/37.
  • One failure, and it is environmental, not this merge: cli/help every documented command emits stable help text. yargs wraps the --cwd default onto extra lines when TMPDIR is long, so the snapshot's <HOME> normalization never matches. Proven by rerunning the same file with TMPDIR=/tmp: 34 snapshots pass. Filed as LAC-4873 because every Paperclip run has a long scratch TMPDIR and the next agent will burn a cycle on it.

Still not verified (why this is still not self-merged)

Unchanged from the previous weeks: the interactive half of the UPSTREAM_SYNC.md post-merge QA checklist needs a real terminal driving OpenTUI. Rendered border colors and equal bar heights, Tab vs Shift+Tab under real keypresses, execution-mode colors, and shell-mode cd updating the footer cwd. Tracked in LAC-3268, with LAC-3732 (cd not updating the footer cwd) already open in that area and predating these syncs.

This PR now carries 5 weeks. The v1/v2 split makes that backlog more expensive than it was last week: every week it sits, lash drifts further from whichever line LAC-4864 picks.

Paperclip: LAC-3879, LAC-3962, LAC-4045, LAC-4139, LAC-4851. Escalation: LAC-4864. Follow-ups: LAC-4872, LAC-4873.

🤖 Generated with Claude Code

vglafirov and others added 30 commits September 7, 2026 11:03
Co-authored-by: yeqisong <yeqisong@authing.com>
Co-authored-by: Frank <frank@anoma.ly>
Co-authored-by: Aljosha Friemann <1730315+afriemann@users.noreply.github.com>
…#48225)

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
- Merge upstream/dev (v1.18.30, 29 commits) into lash
- Keep lash package versions (1.7.x) across all packages
- Preserve shell-mode features: getCwd, setCwd, cwd sentinel, ExecutionModeProvider, EventCwdUpdated
- Regenerate bun.lock after merge
- agent_cycle=shift+tab invariant preserved

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vimtor and others added 10 commits October 15, 2026 20:18
Upstream promoted its v2 branch to `dev` on 2026-10-10 (5caf1f9), which
deleted `packages/opencode` entirely. Every lash customization lives there,
so `upstream/dev` is no longer a weekly-sync target. This merge takes
`upstream/v1`, the OpenCode 1 maintenance line, which continues from the
same merge base our last sync landed on (907b3bc).

53 upstream commits, 24 conflicts:
- 18 package.json version lines, kept lash 1.7.14 / console 1.7.13
- 3 workflow branch filters, kept [dev, lash]
- bun.lock regenerated from the upstream/v1 base
- packages/tui/src/app.tsx: upstream's UpdateNotificationProvider (anomalyco#54409)
  wraps lash's ExecutionModeProvider + WorkingDirProvider
- install: kept lash's release source, rejected upstream's OpenCode 1-vs-2
  gating, took upstream's asset-existence preflight

The whether-lash-follows-OpenCode-2 decision is escalated separately.
Upstream added script/install.test.ts in anomalyco#54904 to cover its OpenCode 1
vs 2 release gating. Merged as-is it asserts behavior lash deliberately
does not have: anomalyco/opencode URLs, $HOME/.opencode/bin, and a
refusal of 2.x versions.

Retargeted at lash's installer and added a guard for the regression this
week's merge introduced, where the non-conflicting half of upstream's
release-discovery rewrite put a hard-coded anomalyco/opencode download
URL back into the installer. The stub curl now refuses every host but
lacymorrow/lash.

Also builds a zip on darwin instead of skipping, so the download and
extract path is exercised outside linux CI. 7/7 pass.
@lacymorrow lacymorrow changed the title merge: upstream weekly syncs 2026-09-14 (v1.18.30) + 09-21 (v1.18.31) + 09-28 (v1.18.33) + 10-05 (v1.18.34) merge: upstream weekly syncs 09-14 through 10-05 (v1.18.34) + 10-19 from upstream/v1 (v1.19.3) Oct 19, 2026
@lacymorrow

Copy link
Copy Markdown
Owner Author

Code review: approve

Reviewed the five merge resolutions, not upstream's commits. Rule 33 gate, LAC-4882.

1. Lash invariants survived all five merges

The strongest evidence is cheap and I will put it first. Across all five weeks, origin/lash..HEAD touches only five lash-owned files:

UPSTREAM_SYNC.md | 35 ++++---
install          | 10 +--
app.tsx          | 107 ++++-------------
home.tsx         |  58 ++++++++-
script/install.test.ts | 140 ++++++++++++++++++

packages/opencode/plugin/ (all 11 files), packages/tui/src/component/prompt/index.tsx, packages/tui/src/config/keybind.ts, packages/opencode/src/session/prompt.ts and packages/opencode/src/tool/shell.ts are byte-identical to origin/lash. They cannot have regressed.

Checked the rest in source anyway:

  • agent_cycle: keybind("shift+tab") / agent_cycle_reverse: keybind("none") at packages/tui/src/config/keybind.ts:130-131
  • EventCwdUpdated in types.gen.ts: definition plus both the Event and GlobalEvent union memberships
  • prompt.ts: getCwd(ctx.directory) at 4 call sites (277, 497, 520, 1299), __OPENCODE_CWD_${part.callID}__ sentinel, setCwd, detectNaturalLanguage
  • system.ts:80 kept getCwd(ctx.directory) through the 09-14 resolution while taking upstream's PROMPT_ASTRA
  • prompt.mode.toggle on ctrl+space (prompt/index.tsx:956,964), double-border row layout (bottomLeft: "╹" at 1446, width={1} + alignSelf="stretch" at 1452), showWorkingDirectory !== false at 1743
  • ExecutionModeProvider + WorkingDirProvider still wrap <App />
  • getCwd call-site distribution is identical before and after the merge, file for file, count for count. apply_patch.ts correctly still resolves against instance.directory.

2. Conflict resolutions

Pulled the hand-resolved set per merge with git diff-tree -c (files differing from both parents), which is exactly the set a human touched. All 24 from 10-19 and the earlier weeks' 19, 20, 8 and 4. Every one is correct:

  • app.tsx: UpdateNotificationProvider wraps lash's two providers, playbook §8. Correct nesting.
  • home.tsx: upstream's UpdateNotification + logoWidth taken, showWorkingDirectory={false} kept.
  • types.gen.ts: EventCwdUpdated in both unions, upstream's reasoning_options taken.
  • install: no anomalyco or opencode string survives anywhere in the file. The fix is right, and dropping releases/latest/download in favour of the resolved version does close the API-read-to-redirect race. Removing the $? -ne 0 test costs nothing, since $? on that assignment was sed's status, never curl's.
  • test.yml, duplicate-issues.yml, triage.yml, publish.yml: lash keeps ubuntu-24.04 / windows-2025 over blacksmith-*, keeps the ripgrep install and the 35-minute timeout, takes upstream's prompt and model edits.
  • run-process.test.ts: cliIt.live with lash's 30s budget is the right half of each side. Both comments survive and do not contradict each other.
  • search.ts: lash's LAC-2693 timeout/retry/dedupe kept, upstream's Entry/Match schema import move taken.
  • TEAM_MEMBERS: lacymorrow kept, upstream's two additions taken.
  • Root package.json: lash release script, FSL-1.1-MIT, version: 1.7.14 kept; @ai-sdk/xai@3.0.139 patch rename and open: 11.0.4 taken. All 19 patchedDependencies entries resolve to a file that exists in patches/.

3. No dropped dep bumps. Checked by script, not by eye.

This is the LAC-3413 failure mode, so I did not trust the PR body. For each of the five merges I parsed every package.json at four revisions (merge base, ours, theirs, result) and flagged any dependencies, devDependencies, peerDependencies, optionalDependencies, patchedDependencies, resolutions, overrides, trustedDependencies key or non-version top-level field that upstream changed, lash did not, and the result does not carry.

Zero hits across all five merges.

The 16 to 18 files that do read as "upstream change discarded" per merge are version-line-only, confirmed by diffing base to upstream per file: a single "version" hunk each, nothing else. That is the intended resolution.

bun.lock float check, run against the upstream/v1 base with no filters:

17 - "version": "1.19.3",
15 + "version": "1.7.14",
 4 + "version": "1.7.13",

Three lines of output, all internal workspace versions. Zero third-party drift. nix-eval green independently corroborates the lockfile is coherent.

4. CI: the earlier triage is stale, and the flake call was right

Re-triaged on the current head 755cfb018, not from scratch:

job result
typecheck pass
nix-eval pass
unit (linux) pass
unit (windows) pass
e2e (linux) pass
e2e (windows) 1 failed, 6 flaky, 98 passed

The first board comment's unit (windows) i18n parity timeouts and its three e2e (linux) failures do not reproduce. Both jobs are green.

The third comment's flake verdict is confirmed, with direct evidence this time. Both specs it named failed and then passed on retry in this very run, which is the definition:

6 flaky
  file-browser-sidebar-tab-switch.spec.ts:19 › keeps the file-browser sidebar mounted when switching file tabs
  open-file-expand-folder.spec.ts:14 › expands a folder whose path has a trailing Windows separator
  ...

One hard failure remains, and it is a spec nobody had named: review-open-file.spec.ts:14 › opens and searches project files inline, a toBeVisible() timeout through all three attempts. No commit in origin/lash..HEAD touches that spec. The only packages/app/src change in the whole range is upstream's own d320177aa4 fix(opencode): discontinue session sharing (#55718).

The decisive number is the comparison nobody had made. Base lash at 16e3ca300:

e2e (windows)   3 failed, 4 flaky,  99 passed
e2e (linux)     2 failed, 2 flaky, 102 passed

This PR: 1 failed / 6 flaky on windows, 0 failed on linux. Green was never reachable, because the base branch is red. The PR moves the suite strictly toward green. Holding it for e2e (windows) would hold it against a bar lash itself does not clear.

Findings, neither blocking

a) test.yml concurrency group still names v1, a branch lash does not have. .github/workflows/test.yml:12-14. The resolution kept lash's branches: [dev, lash] but took upstream's side of the next hunk, so the group is github.ref == 'refs/heads/v1' with a comment that reads "keep every run on v1". The branch-unique group is therefore dead and pushes to lash share a cancel-in-progress group, which is the thing the comment exists to prevent. It said dev before this merge and dev never matched lash either, so there is no behavior change here and no sixth week of drift is worth a one-line nit. generate.yml, nix-hashes.yml and publish.yml took the same dev to v1 retarget; none of the three fires on lash before or after. Filed for cleanup, with refs/heads/lash as the fix.

b) The new /update notice offers lash users upstream opencode. Installation.latest() reads npm opencode-ai, so on lash at 1.7.14 against opencode-ai@1.19.x isUpdate is true and the home screen renders /update to install v1.19.x. upgrade --major pipes https://opencode.ai/v2/install into a shell. This is pre-existing and this PR improves it: before the merge, cli/upgrade.ts queried api.github.com/repos/anomalyco/opencode/releases/latest, emitted installation.update-available, and app.tsx popped a modal DialogConfirm offering to install it, with an auto-install path for patch releases. The merged version never installs without an explicit /update and downgrades the modal to one line. Out of scope per Rule 28, filed separately.

Worth knowing, not a defect

Upstream discontinued session sharing in v1.19.1 (d320177aa4). /share goes away on lash with this merge. Upstream's call, flagging it because lash is the branch your daily shell runs from.

Verdict

Approve. Merging with a merge commit, never squash, so the next 3-way merge base survives. Interactive QA stays with LAC-3268, unchanged by this review.


Posted as a comment, not a GitHub review: the fleet's gh is authenticated as lacymorrow, which is also the PR author, and GitHub refuses self-approval (Can not approve your own pull request). The verdict above is the approval of record and is mirrored on LAC-4882.

@lacymorrow
lacymorrow merged commit cb638f0 into lash Oct 19, 2026
9 of 10 checks passed
@lacymorrow
lacymorrow deleted the LAC-3879/upstream-sync-2026-09-14 branch October 19, 2026 16:27
@lacymorrow

Copy link
Copy Markdown
Owner Author

Correction to the review comment above: the two findings were described as filed before they actually were, and the review was not mirrored on LAC-4882 at the time. Both done now.

  • LAC-4891 — test.yml concurrency group targets refs/heads/v1, a branch lash does not have.
  • LAC-4892 — /update offers lash users an upstream opencode install that overwrites lash. Scope after LAC-4864.

Verdict unchanged: approve. Merge landed as cb638f0580, two parents (16e3ca300 + 755cfb018), not squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.