Julia

[cortner]

Just a regular PR to keep main and julia synchronized.

[cortner]

@Luthaf -- sorry I missed your message. Thank you, No proper review needed, just a sanity check that I'm not messing with anything in main.

[Luthaf]

The code looks fine, but CI seems broken. I'll investiguate what's going on!

Is this all the changes you want to make & merge for now?

[cortner]

The julia branch is just where I'll continue to develop, and after every release I'll make a PR to synchronize with main. So after the PR the julia branch just remains my development branch.

Is that ok for you?

[Luthaf]

Is that ok for you?

Yes, this is fine.

The CI error seems relevant to these changes:

ERROR: Unsatisfiable requirements detected for package LinearAlgebra [37e2e46d]:
 LinearAlgebra [37e2e46d] log:
 ├─possible versions are: 1.9.2 or uninstalled (package in sysimage!)
 └─restricted to versions 1.10.0-1 by SpheriCart [5caf2b29] — no versions left
   └─SpheriCart [5caf2b29] log:
     ├─possible versions are: 0.2.1 or uninstalled
     └─SpheriCart [5caf2b29] is fixed to version 0.2.1

[cortner]

that's weird, I thought I had already fixed this. I'll figure this out and ping you again when it is ready to merge.

[cortner]

@Luthaf -- unsure why this still fails, I only changed the Julia version in the CI script. But the failure seems to be elsehwere now?

[Luthaf]

Yes, the new failure is unrelated, this is a new version of clang-format not being happy with our C++ code. I'll fix it separately and update this branch!

[Luthaf]

Tests now fail on macOS with

 KernelAbstractions: Error During Test at /Users/runner/work/sphericart/sphericart/julia/test/runtests.jl:8
  Got exception outside of a @test
  LoadError: ArgumentError: Package CUDA not found in current path.
  - Run `import Pkg; Pkg.add("CUDA")` to install the CUDA package.

Should I remove the macOS tests or is the OS still supported?

[cortner]

there are multiple problems that I don't see locally. I prefer to fix them before merging.

[cortner]

I suspect the Julia test action is not correctly specified. I normally just use defaults provided by the Juli apackage manager, I'll have to look into it.

[cortner]

The problem is that this line

julia --project=.. runtests.jl

doesn't actually run the Julia tests correctly as it doesn't load the test dependencies.

I tried to modify this as I think is correct. If this fails, then we may need to setup a separate test action and we can copy-paste in the standard Julia test script.

[cortner]

tests seem to run ok now now I get a function call error that I need to track down. Weird how I don't see any of this locally.

[cortner]

@Luthaf -- fingers crossed I fixed the final problem. It also seems there might be a time-out problem on one of the tests? Not sure how to fix the test script. And have I re-introduced old problems with the other CI scripts?

[Luthaf]

Everything looks good!

It also seems there might be a time-out problem on one of the tests?

What makes you think so? If it is the red cross on the merge commit, this is because you pushed another commit before CI could finish, so it canceled the first CI run. But then CI for the latest commit ran to completion!

[cortner]

I thought I saw some other errors, but great that everything passed now. From my end this is then ready to merge. Thank you for your patience.