validate the eni status to inUse

resent eni attach behave changed, it will fail and  rollback to Available , so check is necessary

Signed-off-by: l1b0k <[email protected]>

pkg/aliyun/client/ecs.go

@@ -152,7 +152,7 @@ func (a *OpenAPI) DescribeNetworkInterface(ctx context.Context, vpcID string, en
 			result = append(result, FromDescribeResp(&r))
 		}
 
-		l.V(4).Info("describe enis")
+		l.WithValues(LogFieldRequestID, resp.RequestId).Info("describe enis")
 
 		if len(resp.NetworkInterfaceSets.NetworkInterfaceSet) < maxSinglePageSize {
 			break

pkg/factory/aliyun/aliyun.go

@@ -2,6 +2,7 @@ package aliyun
 
 import (
 	"context"
+	"fmt"
 	"net/netip"
 	"strings"
 	"time"
@@ -180,6 +181,8 @@ func (a *Aliyun) CreateNetworkInterface(ipv4, ipv6 int, eniType string) (*daemon
 		return r, nil, nil, err
 	}
 
+	timeout := time.After(2 * time.Second)
+
 	// 3. wait metadata ready & update cidr
 	err = validateIPInMetadata(ctx, v4Set, func() []netip.Addr {
 		exists, err := metadata.GetIPv4ByMac(r.MAC)
@@ -242,6 +245,34 @@ func (a *Aliyun) CreateNetworkInterface(ipv4, ipv6 int, eniType string) (*daemon
 		r.GatewayIP.SetIP(gw.String())
 	}
 
+	// safe to use in go 1.23
+	<-timeout
+
+	var innerErr error
+	// we check openAPI at last to ensure the eni is at InUse status
+	err = wait.ExponentialBackoffWithContext(a.ctx, backoff.Backoff(backoff.ENIOps), func(ctx context.Context) (done bool, err error) {
+		var eniSet []*client.NetworkInterface
+		eniSet, innerErr = a.openAPI.DescribeNetworkInterface(ctx, "", []string{r.ID}, "", "", "", nil)
+		if innerErr != nil {
+			return false, nil
+		}
+		if len(eniSet) != 1 {
+			innerErr = fmt.Errorf("can not found eni %s, resp %#v", r.ID, eniSet)
+			return false, nil
+		}
+		if eniSet[0].Status != client.ENIStatusInUse {
+			innerErr = fmt.Errorf("eni %s at %s", r.ID, eniSet[0].Status)
+			return false, nil
+		}
+		return true, nil
+	})
+	if err != nil {
+		if innerErr != nil {
+			err = innerErr
+		}
+		return r, v4Set, v6Set, err
+	}
+
 	return r, v4Set, v6Set, nil
 }