Fix: amended dots in the policy field could never appear - #82
Merged
Conversation
…o record uses The register treats amendment as an event: policies stay active and carry an amended date. The beeswarm coloured by status, so its amber legend entry could never occur. Twelve dots now show it, with the 30-day new override keeping precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharp catch from review of the live hero: the Policy Field legend advertises an amber "Amended" category, but the dots were coloured by policy status — and no record carries status
amended, because this register treats amendment as an event: the policy staysactiveand gains anamendeddate (12 records have one).Dots now colour by the primary date's type, so a policy whose latest lifecycle event is an amendment shows amber. The 30-day "New" override keeps precedence, so fresh amendments show blue first and turn amber as they age.
Verified on Argus: typecheck, lint, 442/442 tests, build; screenshot confirms roughly a dozen amber dots across five jurisdictions, none before.
🤖 Generated with Claude Code