Skip to content

Commit

Permalink
Increase timeout in tests and review redundant JSON changes
Browse files Browse the repository at this point in the history
Updated `incrementTestDoneSignal.Wait` timeout from 5s to 10s in
`UsingInterlockedOps.cs` to ensure tests have sufficient time to
complete. Reviewed `xunit.runner.json` for redundant changes to
`parallelizeTestCollections` property, which remains set to `true`.
  • Loading branch information
kzdev-net committed Jan 3, 2025
1 parent 972cd5c commit a8baf02
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
"parallelizeAssembly": true,
"parallelizeTestCollections" : true,
"parallelizeTestCollections" : true
}
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ private void UsingInterlockedOps_IntegerOperation_WithContention_SavesProperResu
// Signal the increment thread to run
runIncrementSignal.Set();
// Wait for the increment thread to finish
incrementTestDoneSignal.Wait(5000).Should().BeTrue();
incrementTestDoneSignal.Wait(10_000).Should().BeTrue();
if (exceptionDispatchInfo is not null)
{
TestWriteLine($"Exception found on loop #{loop}");
Expand Down Expand Up @@ -281,7 +281,7 @@ private void UsingInterlockedOps_UnsignedIntegerOperation_WithContention_SavesPr
// Signal the increment thread to run
runIncrementSignal.Set();
// Wait for the increment thread to finish
incrementTestDoneSignal.Wait(5000).Should().BeTrue();
incrementTestDoneSignal.Wait(10_000).Should().BeTrue();
if (exceptionDispatchInfo is not null)
{
TestWriteLine($"Exception found on loop #{loop}");
Expand Down Expand Up @@ -468,7 +468,7 @@ private void UsingInterlockedOps_LongIntegerOperation_WithContention_SavesProper
// Signal the increment thread to run
runIncrementSignal.Set();
// Wait for the increment thread to finish
incrementTestDoneSignal.Wait(5000).Should().BeTrue();
incrementTestDoneSignal.Wait(10_000).Should().BeTrue();
if (exceptionDispatchInfo is not null)
{
TestWriteLine($"Exception found on loop #{loop}");
Expand Down Expand Up @@ -649,7 +649,7 @@ private void UsingInterlockedOps_UnsignedLongIntegerOperation_WithContention_Sav
// Signal the increment thread to run
runIncrementSignal.Set();
// Wait for the increment thread to finish
incrementTestDoneSignal.Wait(5000).Should().BeTrue();
incrementTestDoneSignal.Wait(10_000).Should().BeTrue();
if (exceptionDispatchInfo is not null)
{
TestWriteLine($"Exception found on loop #{loop}");
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
"parallelizeAssembly": true,
"parallelizeTestCollections" : true,
"parallelizeTestCollections" : true
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
"parallelizeAssembly": true,
"parallelizeTestCollections" : true,
"parallelizeTestCollections" : true
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
"parallelizeAssembly": true,
"parallelizeTestCollections" : true,
"parallelizeTestCollections" : true
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
"parallelizeAssembly": true,
"parallelizeTestCollections" : true,
"parallelizeTestCollections" : true
}

0 comments on commit a8baf02

Please sign in to comment.