Skip to content

Add Create Mod Trains Compatibility With Portals#101

Open
TheRobbie73 wants to merge 4 commits intokyrptonaught:1.18from
TheRobbie73:1.18
Open

Add Create Mod Trains Compatibility With Portals#101
TheRobbie73 wants to merge 4 commits intokyrptonaught:1.18from
TheRobbie73:1.18

Conversation

@TheRobbie73
Copy link

@TheRobbie73 TheRobbie73 commented May 20, 2024

Adds compatibility between Create trains and customportalapi

image

ezgif-2-2b4cbf544e

@lexi-the-cute
Copy link

nice! will have to see if i can get this to work on the 1.20.1 version

@lexi-the-cute
Copy link

lexi-the-cute commented Jul 11, 2024

well, the cherry picked code with changes loads and the nether side of things works, but am still dealing with the tracks not picking up the custom portals at all. this is in my attempt to get this pr into 1.20.1

edit: turns out that datapack portals is in fact not using the customportalapi jar built into its jar cause i just removed it and the portals themselves still work and light. so it wasnt even running my modified code when i swapped out the jars

edit 2: i think something in the pack is also adding customportalapi

@lexi-the-cute
Copy link

yes, another mod is adding its own copy of CustomPortalApi and i need to track it down. i did manage to successfully cherry pick this PR and get it working on 1.20.1 with the latest Create scm-repo-mirror@d8f877a

2024-07-11_08 35 02

@lexi-the-cute
Copy link

definitely feel like im being punked. it works in single player, but then has create throw the "portal not generated on other side" error message in multiplayer when i install it on the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants