Skip to content

Conversation

@qwertycxz
Copy link

@qwertycxz qwertycxz commented May 19, 2025

Fix #357.

  1. Fix that some commands that shouldn't have been filtered are filtered in Paper.
  2. Fix that no commands are filtered in Bungeecord.
  3. Fix that all commands are filtered in Velocity.
Contrast

Paper

execute command: /login password & /list & /about

Before

$ log in
[12:00:00 INFO]: UUID of player foo is xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
[12:00:00 INFO]: foo joined the game
[12:00:00 INFO]: foo[/127.0.0.1:12345] logged in with entity id 100 at ([limbo]0.0, 70.0, 0.0)
$ /login password # no logging as expected
$ /list # unexpected no logging
$ /about # logging as expected
[12:00:15 INFO]: foo issued server command: /about

Now

$ log in
[12:00:00 INFO]: UUID of player foo is xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
[12:00:00 INFO]: foo joined the game
[12:00:00 INFO]: foo[/127.0.0.1:12345] logged in with entity id 100 at ([limbo]0.0, 70.0, 0.0)
$ /login password # no logging as expected
$ /list # logging as expected
[12:00:10 INFO]: foo issued server command: /list
$ /about # logging as expected
[12:00:15 INFO]: foo issued server command: /about

Bungeecord

Logs are localized.

execute command: /login password & /glist & /bungee

Before

$ log in
12:00:00 [信息] [/127.0.0.1:12345] <-> InitialHandler has connected
12:00:00 [信息] [foo] <-> ServerConnector [limbo] has connected
$ /login password # unexpected logging
12:00:05 [信息] foo executed command: /login password
12:00:05 [信息] [foo] <-> ServerConnector [paper] has connected
12:00:05 [信息] [foo] <-> DownstreamBridge <-> [limbo] has disconnected
$ /glist # logging as expected
12:00:10 [信息] foo executed command: /glist
$ /bungeecord # logging as expected
12:00:15 [信息] foo executed command: /bungee

Now

$ log in
12:00:00 [信息] [/127.0.0.1:12345] <-> InitialHandler has connected
12:00:00 [信息] [foo] <-> ServerConnector [limbo] has connected
$ /login password # no logging as expected
12:00:05 [信息] [foo] <-> ServerConnector [paper] has connected
12:00:05 [信息] [foo] <-> DownstreamBridge <-> [limbo] has disconnected
$ /glist # logging as expected
12:00:10 [信息] foo executed command: /glist
$ /bungeecord # logging as expected
12:00:15 [信息] foo executed command: /bungee

Velocity

log-command-executions = true

execute command: /login password & /list & /about

Before

$ log in
[12:00:00 INFO]: [connected player] foo (/127.0.0.1:12345) has connected
[12:00:00 INFO]: [server connection] foo -> limbo has connected
[12:00:05 INFO]: [server connection] foo -> paper has connected
[12:00:05 INFO]: [server connection] foo -> limbo has disconnected
$ /login password # no logging as expected
$ /list # unexpected no logging
$ /about # unexpected no logging

Now

$ log in
[12:00:00 INFO]: [connected player] foo (/127.0.0.1:12345) has connected
[12:00:00 INFO]: [server connection] foo -> limbo has connected
[12:00:05 INFO]: [server connection] foo -> paper has connected
[12:00:05 INFO]: [server connection] foo -> limbo has disconnected
$ /login password # no logging as expected
$ /list # logging as expected
[12:00:10 INFO]: [connected player] foo (/127.0.0.1:12345) -> executed command /list
$ /about # logging as expected
[12:00:15 INFO]: [connected player] foo (/127.0.0.1:12345) -> executed command /about

This is a severe glitch. We need to fix it ASAP.

Although this glitch has existed for years.

1. Fix that some commands that shouldn't have been filtered are filtered in Paper.
2. Fix that no commands are filtered in Bungeecord.
3. Fix that all commands are filtered in Velocity.
In short, the once problematic LogFilter now works as expected.
@qwertycxz
Copy link
Author

qwertycxz commented May 19, 2025

I have a prebuilt .jar, in case that anyone need it.
LibreLogin.jar.gz
Java >= 21 is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] LogFilter messed up log-command-executions

1 participant