Skip to content

use indexes for lowercase nicknames #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
professorparabellum wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −6
Open

use indexes for lowercase nicknames #328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d033483
use indexes for lowercase nicknames
professorparabellum Feb 9, 2025
a91d345
Merge branch 'kyngs:dev' into dev
professorparabellum Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ain/java/xyz/kyngs/librelogin/common/database/provider/LibreLoginSQLDatabaseProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,13 @@ public Collection<User> getByIP(String ip) {
public User getByName(String name) {
plugin.reportMainThread();
return connector.runQuery(connection -> {
var ps = connection.prepareStatement("SELECT * FROM librepremium_data WHERE LOWER(last_nickname)=LOWER(?)");
var ps = connection.prepareStatement("SELECT * FROM librepremium_data WHERE last_nickname_lower = ?");

ps.setString(1, name);
ps.setString(1, name.toLowerCase());

var rs = ps.executeQuery();

return getUserFromResult(rs);

});
}

Expand Down Expand Up @@ -236,7 +235,8 @@ public void validateSchema() {
"hashed_password VARCHAR(255)," +
"salt VARCHAR(255)," +
"algo VARCHAR(255)," +
"last_nickname VARCHAR(255) NOT NULL UNIQUE," +
"last_nickname VARCHAR(255) NOT NULL," +
"last_nickname_lower VARCHAR(255) AS (LOWER(last_nickname)) STORED," +
"joined TIMESTAMP NULL DEFAULT NULL," +
"last_seen TIMESTAMP NULL DEFAULT NULL," +
"last_server VARCHAR(255)" +
Expand All @@ -261,12 +261,12 @@ public void validateSchema() {
}
if (!columns.contains("email")) {
connection.prepareStatement("ALTER TABLE librepremium_data ADD COLUMN email VARCHAR(255) NULL DEFAULT NULL").executeUpdate();
}

try {
connection.prepareStatement(addUnique("last_nickname")).executeUpdate();
connection.prepareStatement("CREATE UNIQUE INDEX idx_nickname_lower ON librepremium_data (last_nickname_lower)").executeUpdate();
} catch (SQLException ignored) {
}
}
});
}

Expand Down