Skip to content

Added Petri Consensus #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcsenpai wants to merge 54 commits into
base: stabilisation
Choose a base branch
from

fix: add local mempool fallback when Petri relay fails

7f6ce72
Select commit
Loading
Failed to load commit list.
Open

Added Petri Consensus #692

fix: add local mempool fallback when Petri relay fails
7f6ce72
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 23, 2026 in 1m 26s

Quality Gate passed

Issues
93 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 392 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Review this redundant assignment: "agreed" already holds the assigned value along all execution paths. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNs&open=AZ0ar7-US-WNYeg2jWNs&pullRequest=692

Check warning on line 389 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNq&open=AZ0ar7-US-WNYeg2jWNq&pullRequest=692

Check warning on line 9 in src/libs/consensus/petri/routing/shardMapper.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar72gS-WNYeg2jWMq&open=AZ0ar72gS-WNYeg2jWMq&pullRequest=692

Check warning on line 26 in testing/loadgen/src/features/consensus/petri_soak.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'waitForBlockAdvance'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79aS-WNYeg2jWM-&open=AZ0ar79aS-WNYeg2jWM-&pullRequest=692

Check warning on line 97 in testing/petri/conflictPath.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "flagged". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-_S-WNYeg2jWN7&open=AZ0ar7-_S-WNYeg2jWN7&pullRequest=692

Check warning on line 358 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNl&open=AZ0ar7-US-WNYeg2jWNl&pullRequest=692

Check warning on line 145 in src/libs/consensus/petri/block/petriBlockCompiler.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar711S-WNYeg2jWMg&open=AZ0ar711S-WNYeg2jWMg&pullRequest=692

Check warning on line 137 in src/libs/consensus/petri/arbitration/bftArbitrator.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar73FS-WNYeg2jWMw&open=AZ0ar73FS-WNYeg2jWMw&pullRequest=692

Check warning on line 119 in testing/loadgen/src/features/consensus/petri_soak.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`new Error()` is too unspecific for a type check. Use `new TypeError()` instead. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79aS-WNYeg2jWNE&open=AZ0ar79aS-WNYeg2jWNE&pullRequest=692

Check warning on line 124 in testing/loadgen/src/features/consensus/petri_relay_flow.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79kS-WNYeg2jWNQ&open=AZ0ar79kS-WNYeg2jWNQ&pullRequest=692

Check warning on line 117 in testing/loadgen/src/features/consensus/petri_tx_inclusion.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79sS-WNYeg2jWNW&open=AZ0ar79sS-WNYeg2jWNW&pullRequest=692

Check failure on line 142 in src/libs/consensus/petri/coordination/petriSecretary.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar720S-WNYeg2jWMt&open=AZ0ar720S-WNYeg2jWMt&pullRequest=692

Check failure on line 94 in testing/loadgen/src/features/consensus/petri_tx_inclusion.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79sS-WNYeg2jWNS&open=AZ0ar79sS-WNYeg2jWNS&pullRequest=692

Check warning on line 411 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNt&open=AZ0ar7-US-WNYeg2jWNt&pullRequest=692

Check warning on line 162 in src/libs/blockchain/l2ps_mempool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar76TS-WNYeg2jWM7&open=AZ0ar76TS-WNYeg2jWM7&pullRequest=692

Check warning on line 210 in testing/petri/blockCompiler.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-fS-WNYeg2jWNz&open=AZ0ar7-fS-WNYeg2jWNz&pullRequest=692

Check warning on line 105 in testing/loadgen/src/features/consensus/petri_tx_inclusion.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79sS-WNYeg2jWNT&open=AZ0ar79sS-WNYeg2jWNT&pullRequest=692

Check warning on line 337 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNj&open=AZ0ar7-US-WNYeg2jWNj&pullRequest=692

Check warning on line 210 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNd&open=AZ0ar7-US-WNYeg2jWNd&pullRequest=692

Check warning on line 353 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNk&open=AZ0ar7-US-WNYeg2jWNk&pullRequest=692

Check warning on line 110 in testing/loadgen/src/features/consensus/petri_soak.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar79aS-WNYeg2jWNB&open=AZ0ar79aS-WNYeg2jWNB&pullRequest=692

Check warning on line 30 in src/libs/consensus/petri/forge/continuousForge.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'state' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar72AS-WNYeg2jWMh&open=AZ0ar72AS-WNYeg2jWMh&pullRequest=692

Check warning on line 384 in testing/petri/secretaryCoordination.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar7-US-WNYeg2jWNp&open=AZ0ar7-US-WNYeg2jWNp&pullRequest=692

Check failure on line 42 in src/libs/network/endpointExecution.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 58 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar71nS-WNYeg2jWMf&open=AZ0ar71nS-WNYeg2jWMf&pullRequest=692

Check failure on line 9 in src/libs/consensus/v2/routines/broadcastBlockHash.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0ar74rS-WNYeg2jWM4&open=AZ0ar74rS-WNYeg2jWM4&pullRequest=692
View more details on SonarQubeCloud