Skip to content

feat(l2ps-messaging): add crypto and integration tests for messaging … #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shitikyan wants to merge 3 commits into
base: testnet
Choose a base branch
from

feat(l2ps-messaging): enforce registration checks before peer discove…

4df26f3
Select commit
Loading
Failed to load commit list.
Open

feat(l2ps-messaging): add crypto and integration tests for messaging … #686

feat(l2ps-messaging): enforce registration checks before peer discove…
4df26f3
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 10, 2026 in 27s

Quality Gate failed

Failed conditions
3 Security Hotspots
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 9 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'L2PSMessagingServer'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4Y&open=AZzX4FYYzSB7bvLMig4Y&pullRequest=686

Check warning on line 170 in src/features/l2ps-messaging/L2PSMessagingService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYizSB7bvLMig4j&open=AZzX4FYizSB7bvLMig4j&pullRequest=686

Check warning on line 37 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "ws". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4a&open=AZzX4FYYzSB7bvLMig4a&pullRequest=686

Check warning on line 8 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'afterEach'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4V&open=AZzX4FYYzSB7bvLMig4V&pullRequest=686

Check warning on line 175 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4c&open=AZzX4FYYzSB7bvLMig4c&pullRequest=686

Check warning on line 237 in src/features/l2ps-messaging/L2PSMessagingServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYyzSB7bvLMig4u&open=AZzX4FYyzSB7bvLMig4u&pullRequest=686

Check warning on line 434 in src/features/l2ps-messaging/L2PSMessagingServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYyzSB7bvLMig4v&open=AZzX4FYyzSB7bvLMig4v&pullRequest=686

Check warning on line 16 in src/features/l2ps-messaging/L2PSMessagingService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Hashing'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYizSB7bvLMig4g&open=AZzX4FYizSB7bvLMig4g&pullRequest=686

Check warning on line 109 in src/features/l2ps-messaging/L2PSMessagingServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYyzSB7bvLMig4s&open=AZzX4FYyzSB7bvLMig4s&pullRequest=686

Check warning on line 204 in src/features/l2ps-messaging/tests/L2PSMessagingService.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.at(…)` over `[….length - index]`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYOzSB7bvLMig4T&open=AZzX4FYOzSB7bvLMig4T&pullRequest=686

Check warning on line 220 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Review this usage of "peers" as it can only be empty here. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4e&open=AZzX4FYYzSB7bvLMig4e&pullRequest=686

Check warning on line 175 in src/features/l2ps-messaging/L2PSMessagingService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYizSB7bvLMig4l&open=AZzX4FYizSB7bvLMig4l&pullRequest=686

Check warning on line 38 in src/features/l2ps-messaging/L2PSMessagingServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'service' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYyzSB7bvLMig4r&open=AZzX4FYyzSB7bvLMig4r&pullRequest=686

Check failure on line 41 in src/features/l2ps-messaging/tests/integration.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYEzSB7bvLMig4O&open=AZzX4FYEzSB7bvLMig4O&pullRequest=686

Check warning on line 149 in src/features/l2ps-messaging/L2PSMessagingService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYizSB7bvLMig4i&open=AZzX4FYizSB7bvLMig4i&pullRequest=686

Check warning on line 8 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'mock'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4W&open=AZzX4FYYzSB7bvLMig4W&pullRequest=686

Check warning on line 628 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FZozSB7bvLMig4y&open=AZzX4FZozSB7bvLMig4y&pullRequest=686

Check warning on line 171 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4b&open=AZzX4FYYzSB7bvLMig4b&pullRequest=686

Check warning on line 8 in src/features/l2ps-messaging/tests/L2PSMessagingServer.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'beforeEach'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYYzSB7bvLMig4U&open=AZzX4FYYzSB7bvLMig4U&pullRequest=686

Check warning on line 179 in src/features/l2ps-messaging/L2PSMessagingService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'execError' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYizSB7bvLMig4m&open=AZzX4FYizSB7bvLMig4m&pullRequest=686

Check warning on line 37 in src/features/l2ps-messaging/L2PSMessagingServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'server' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYyzSB7bvLMig4q&open=AZzX4FYyzSB7bvLMig4q&pullRequest=686

Check warning on line 172 in scripts/l2ps-messaging-test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "joined". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FZ7zSB7bvLMig4z&open=AZzX4FZ7zSB7bvLMig4z&pullRequest=686

Check warning on line 189 in src/features/l2ps-messaging/L2PSMessagingService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'recordError' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYizSB7bvLMig4o&open=AZzX4FYizSB7bvLMig4o&pullRequest=686

Check warning on line 195 in src/features/l2ps-messaging/tests/L2PSMessagingService.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "status". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYOzSB7bvLMig4S&open=AZzX4FYOzSB7bvLMig4S&pullRequest=686

Check warning on line 8 in src/features/l2ps-messaging/tests/L2PSMessagingService.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'beforeEach'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZzX4FYOzSB7bvLMig4Q&open=AZzX4FYOzSB7bvLMig4Q&pullRequest=686
View more details on SonarQubeCloud