Skip to content

chore: refactor reconcilers #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
k15r wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: refactor reconcilers #2717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion controllers/telemetry/logpipeline_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ func configureFluentBitReconciler(config LogPipelineControllerConfig, client cli
logpipelinefluentbit.WithEndpointValidator(&endpoint.Validator{Client: client}),
logpipelinefluentbit.WithTLSCertValidator(tlscert.New(client)),
logpipelinefluentbit.WithSecretRefValidator(&secretref.Validator{Client: client}),
logpipelinefluentbit.WithValidatorPipelineLock(pipelineLock),
)

fluentBitApplierDeleter := fluentbit.NewFluentBitApplierDeleter(
Expand Down
6 changes: 6 additions & 0 deletions internal/reconciler/logpipeline/fluentbit/interfaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,10 @@ type PipelineLock interface {
// Returns nil if the owner holds a lock, or an error if it does not.
// This is used to determine if a pipeline is already registered and active.
IsLockHolder(ctx context.Context, owner metav1.Object) error

// GetLockHolders retrieves the list of current lock holders and populates the provided list.
// The list is a Kubernetes ObjectList that will be filled with the owners holding locks.
// Returns an error if the lock holders cannot be retrieved.
GetLockHolders(ctx context.Context, list client.ObjectList) error
ReleaseLockIfHeld(ctx context.Context, owner metav1.Object) error
}
115 changes: 115 additions & 0 deletions internal/reconciler/logpipeline/fluentbit/mocks/pipeline_lock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading