generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 31
feat: implement support for OAuth2 authentication in the OTLP output #2706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TeodorSAP
wants to merge
35
commits into
kyma-project:main
Choose a base branch
from
TeodorSAP:feat/oauth2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f015a07
Add OAuth2 API definition
TeodorSAP 920c585
Add API-level validation for authentication method types
TeodorSAP 3cc86a0
Change API validation message
TeodorSAP 652c155
Initial otelcollector config implementation
TeodorSAP bfbfa62
Fix Basic Auth check
TeodorSAP 8f8ab14
Fix nil pointer panics
TeodorSAP 3162718
Add UTs
TeodorSAP 0d05342
Fix linting, manifests, CRDs, etc.
TeodorSAP 35a6d7d
Add OAuth2 extension to the other config builders
TeodorSAP b81f54b
Add UTs for the actual configuration, with golden files
TeodorSAP 216f22d
Merge branch 'main' into feat/oauth2
k15r 3a6221f
Add OAuth2 documentation
TeodorSAP 0544737
e2e oauth2 works
k15r cbdbf5e
properly label MTLS tests
k15r ce397e7
remove unnecessary file
k15r 1969475
remove more files
k15r df3fea2
lint-fix
k15r 0f974c2
oops
k15r afd6b85
wait for oauth2 mock
k15r 8091f0d
use the correct url magically fixes the test ... :)
k15r e48ecb7
Implement CRD validation
TeodorSAP 0350736
Generate resources based on validation rules
TeodorSAP 39ee47a
Add e2e test cases for CRD validation rejection
TeodorSAP 8374a2a
Fix CRD validation
TeodorSAP b9f55ee
Fix small spelling mistake
TeodorSAP 747efe8
Merge branch 'main' into feat/oauth2
k15r 906b8af
fix tests?
k15r 53b246a
reorder tests to not run tests from different packages at the same time
k15r c0dbb31
Merge branch 'main' into feat/oauth2
k15r b836332
fix generate images formatting
k15r 86e0f00
remove debug logs
k15r 702afd2
change validation rules
k15r d4740e8
more validation for oauth
k15r 5ee85f9
Merge remote-tracking branch 'upstream/main' into feat/oauth2
k15r dfce266
lint-fix
k15r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note about this:
DISCLAIMER: GRPC output without TLS configuration is not supported by the OTel collector when OAuth2 is enabled.?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to express this in active voice and more user-centric?
Like "If you want to use OAuth2 with gRPC, you must configure TLS."
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will add it. The user will also get a straight-forward message from the CRD validation if they try configuring it without TLS. But might be good to add it to the documentation as well.