Add architecture diagram #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
dbadura
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger,
nataliasitko,
pPrecel,
kwiatekus,
Cortey,
anoipm,
MichalKalke and
halamix2
as code owners
kyma-bot
added
size/S
pPrecel
reviewed
May 9, 2024
There was a problem hiding this comment.
Looks good 👍🏿 thanks for these changes.
One suggestion only. I would suggest reworking arrows between controllers and their sub-resources (in these blue areas). I think arrows representing dependency/read operation should be pointed to the reading resource and can be made by dotted/dashed lines to represent soft dependency. Operators are creating their CRD so it should be pointed to the CRD and be a solid line.
Here is an example how we did such svc in serverless docs.
anoipm
previously approved these changes
May 10, 2024
grego952
approved these changes
May 10, 2024
anoipm
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#826