Skip to content

fix: Integration testing leaked processes on DualCluster #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 21, 2025
Merged

fix: Integration testing leaked processes on DualCluster #2825

merged 7 commits into from
Oct 21, 2025
+214 −11

Conversation

@medmes
Copy link
Member

@medmes medmes commented Oct 17, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Ensures subprocesses started by the DualCluster integration tests are launched with process-group semantics so they can be killed reliably.
  • Adds explicit cleanup paths and deferred teardown in the test harness to stop background processes and wait for goroutines to exit.
  • Adds a test/validation step that asserts there are no leftover processes matching the test helper binaries after test completion (prevents regressions).

Related issue(s)
#2122

@medmes medmes requested a review from a team as a code owner October 17, 2025 10:48
@medmes medmes linked an issue Oct 17, 2025 that may be closed by this pull request
Running integration tests leaves orphaned processes #2122
Closed
@github-actions
Copy link

❌ Manifests created with 'make dry-run-control-plane' changed! Please make sure to check if changes are needed in related repositories like management-plane-charts, runtime-watcher, etc.

LeelaChacha
LeelaChacha requested changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@LeelaChacha LeelaChacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

@LeelaChacha LeelaChacha enabled auto-merge (squash) October 21, 2025 08:10
LeelaChacha
LeelaChacha approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@LeelaChacha LeelaChacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeelaChacha LeelaChacha merged commit 1101c41 into kyma-project:main Oct 21, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeelaChacha LeelaChacha LeelaChacha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running integration tests leaves orphaned processes

2 participants

@medmes @LeelaChacha